fix in _create_custom_type #722
Conversation
-fix prop name because of dataclass prop names -add modelingrule (otherwise the props will not be instantiated)
|
i guess we should add typing!? |
|
would like to change the tests aswell (API-Change)! it makes more sence to let a variant decide the initial value and have the option to predefine a default value by the user!? |
| """ | ||
| properties: [iterable(<name>, <ua.Variant>, <datatype>), ...] | ||
| variables: [iterable(<name>, <ua.Variant>, <datatype>), ...] | ||
| """ |
There was a problem hiding this comment.
I did not even knew these arguments existed. Why can't we add variable and properties in a new call by adding children to the created type node? That is much more flexible and does not take much longer to type
There was a problem hiding this comment.
dont know! stumbled over it and realised that it does not work that well ^^
There was a problem hiding this comment.
maybe better flag is as depcrecated then
There was a problem hiding this comment.
sorry for the delay!
flagging it as depricated will not solve the issue... if you use it you can create a type but it has no modelling rules so our instantiate method will just instantiate the objectnode!
the only thing i added is that i like to pass a list of iterable(name, Variant, Datatype) so the default value for that type can be added via the Variant!
in my opinion a nice feature and i would like to keep it ;)
There was a problem hiding this comment.
but add a small test to make sure it works. Add something in test_common..py
There was a problem hiding this comment.
sure! need to make some changes on the existing tests aswell as some for that specific case!
-fix prop name because of dataclass prop names
-add modelingrule (otherwise the props will not be instantiated)