Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[styhead] drop walnascar compatiblity #2085

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

Villemoes
Copy link

This branch is not, in fact, compatible with walnascar due to oe-core commit 4ccc3bc8266c3.

ravi-prevas and others added 2 commits January 29, 2025 08:59
This branch is not, in fact, compatible with walnascar due to oe-core
commit 4ccc3bc8266c3.
Copy link
Member

@angolini angolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

and also nice to have the license bump commit on the branch as well

@Villemoes
Copy link
Author

and also nice to have the license bump commit on the branch as well

Well, as I pointed out in #2087 , the license bump is actually useless. Look at the changes it does, it merely shuffles the lines around because whatever working the bot did its thing on had find returning the files in another order than the previous time the bot ran... so I'd actually prefer the bot's commit to be excluded.

@Villemoes
Copy link
Author

and also nice to have the license bump commit on the branch as well

I'm actually also rather puzzled why that commit was even added in the first place. "github workflows" is a new thing to me, but from what I can read from .github/workflows/update-license-file.yml, the logic should trigger on any changes to a .inc or .bb file, or daily at midnight UTC. My commit only changes a .conf file, and we certainly haven't passed UTC midnight since I created that branch this morning (CET time).

@angolini
Copy link
Member

My guess is a new branch, but it's the first time I'm seeing this, so I was only gladly surprised

@otavio otavio merged commit 6e0f5c5 into Freescale:styhead Jan 29, 2025
@Villemoes Villemoes deleted the drop-walnascar branch January 30, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants