Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove react from dependencies #338

Merged
merged 6 commits into from
Mar 15, 2024
Merged

Conversation

helciofranco
Copy link
Member

@helciofranco helciofranco commented Mar 14, 2024

Moving fuels to peerDependency.


@fuel-ui/css and @fuel-ui/react are installing multiple react instances.
It can lead to different react versions on the consumer app.

pnpm why react --filter docs

Before After
Screenshot 2024-03-14 at 10 44 48 Screenshot 2024-03-14 at 10 44 29

Copy link
Contributor

github-actions bot commented Mar 14, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 85.37% 2643/3096
🟡 Branches 76.61% 475/620
🟢 Functions 83.88% 281/335
🟢 Lines 90.62% 2347/2590

Test suite run success

202 tests passing in 50 suites.

Report generated by 🧪jest coverage report action from ef499e1

Copy link
Contributor

github-actions bot commented Mar 14, 2024

🚀 Packages released as pr-338.1 tag on NPM:

@helciofranco helciofranco self-assigned this Mar 14, 2024
@helciofranco helciofranco marked this pull request as ready for review March 14, 2024 17:45
@helciofranco helciofranco merged commit b5e00d1 into master Mar 15, 2024
7 checks passed
@helciofranco helciofranco deleted the hf/fix/react-bundle branch March 15, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants