-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add encoding capability to forc-client for variable encoding #4680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayagokalp
added
enhancement
New feature or request
forc-client
Everything related to the `forc-client` crate.
labels
Jun 17, 2023
kayagokalp
commented
Jun 17, 2023
JoshuaBatty
previously approved these changes
Jun 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sdankel
previously approved these changes
Jun 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
JoshuaBatty
previously approved these changes
Jun 26, 2023
sdankel
previously approved these changes
Jun 29, 2023
Conflicts again :( |
JoshuaBatty
approved these changes
Jun 30, 2023
tritao
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #4679.
This PR lays down the foundation for variable encoding in forc-client. Unblocks things like:
forc run
- allow for specifyingmain
arguments for scripts #3439forc-client
- support working with predicates #3440forc call
command for calling contract methods #3446Checklist
Breaking*
orNew Feature
labels where relevant.