EE-1082: Update OI API Intergration URLS #14
Conversation
lib/open_invoice/entities/payment.rb
Outdated
| module Entities | ||
| class Payment < Base | ||
| def index(opts = {}) | ||
| request(:get, "/supplier/#{supplier_uuid}/payment", opts) | ||
| request(:get, "/v1/supplier/#{supplier_uuid}/payment", opts) | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
There were no updates in the docs regrading the payment API... so I am not sure if this needs to be updated? Wanted to check though.
|
A couple q's:
|
|
@mricher2000 Does this PR need to go straight into master? |
There was a problem hiding this comment.
@mricher2000 What do you think about have the version number as an environment variable and referencing the env variable through the code. Would make updating the version in the future less tedious as only 1 point of reference will need to be touched
|
@jgarciafundthrough Love the idea about having the version number as an env var. As it was pretty tedious going through & updating all the urls 😅 I will make that change! Also I don't think it needs to go straight into master... I just didn't see a dev branch? |
|
@mricher2000 oh weird ok. Maybe we can ask the team to see if anyone has worked with the gem before. Daniela might have some feedback/ideas |
Ticket
EE-1082
Changes
Definition of Done