Skip to content

Commit

Permalink
virt-launcher, unit-test: Adapt to ginkgo 2.0
Browse files Browse the repository at this point in the history
The suites were missing a call to gomock.Controller.Finish(),
which verifies calls made to mocks.
With ginkgo v2, support in GinkgoT() was extended and now
Finish doesn't have to be called explicitly anymore.
The suites started to fail, as there were missing or
uncalled methods.

Signed-off-by: Or Shoval <[email protected]>
  • Loading branch information
oshoval committed Mar 20, 2022
1 parent 60224b0 commit 30aae73
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion pkg/virt-launcher/virtwrap/manager_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2197,7 +2197,6 @@ var _ = Describe("migratableDomXML", func() {
BeforeEach(func() {
ctrl = gomock.NewController(GinkgoT())
mockDomain = cli.NewMockVirDomain(ctrl)
mockDomain.EXPECT().Free()
})
It("should remove only the kubevirt migration metadata", func() {
domXML := `<domain type="kvm" id="1">
Expand Down

0 comments on commit 30aae73

Please sign in to comment.