Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding failrun status to geos_ats #21

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

cssherman
Copy link
Collaborator

No description provided.

@cssherman cssherman requested a review from CusiniM May 31, 2024 18:11
@cssherman
Copy link
Collaborator Author

@CusiniM - there isn't an explicit FAILRUN status in geos_ats, so this is my (completely untested) first shot at adding one in. Do we want to enforce a similar code for restarts or to add a separate code?

Do we have a case that regularly fails to run? We could add one pretty easily for testing if not.

@CusiniM
Copy link
Collaborator

CusiniM commented May 31, 2024

@CusiniM - there isn't an explicit FAILRUN status in geos_ats, so this is my (completely untested) first shot at adding one in. Do we want to enforce a similar code for restarts or to add a separate code?

what do you mean by for "restarts"? Like detect fail run for restart steps? I guess it would make sense. Although most times if the geos step works the restart one should work too so maybe it's not that useful.

Do we have a case that regularly fails to run? We could add one pretty easily for testing if not.

NO, we don't. But it's easy to force a case to fail by specifying something wrong in the xml.

@cssherman cssherman requested a review from rrsettgast August 29, 2024 17:04
@cssherman
Copy link
Collaborator Author

Just talking with @rrsettgast - he doesn't think that we need to run an expected fail test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants