Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cull triangles that are entirely in front of the near plane #4

Merged
merged 1 commit into from
May 18, 2016
Merged

Cull triangles that are entirely in front of the near plane #4

merged 1 commit into from
May 18, 2016

Conversation

punkUser
Copy link
Contributor

No description provided.

@jstewart-amd
Copy link
Contributor

Hi @punkUser. Just so you know, we aren't ignoring this. @Anteru definitely wants to merge this change. We had to wait to get our contribution guidelines in order. Now that we have them, can you please respond back to say that you are okay with this part:

IMPORTANT: By creating a pull request, you agree to allow your contribution to be licensed by the project owners under the terms of the MIT License.

Thanks.

@punkUser
Copy link
Contributor Author

punkUser commented Mar 3, 2016

@Anteru explained what was going on last week - no issues :)

Yes I agree to the licensing terms.

@punkUser
Copy link
Contributor Author

Do you need me to do something to get this merged here? I noticed you changed a bunch of whitespace stuff at some point and that may be creating conflicts?

@Anteru
Copy link
Contributor

Anteru commented Mar 23, 2016

No, it's time. I'll merge when I get back into the office.
Am 23.03.2016 8:01 nachm. schrieb punkUser [email protected]:Do you need me to do something to get this merged here? I noticed you changed a bunch of whitespace stuff at some point and that may be creating conflicts?

—You are receiving this because you were mentioned.Reply to this email directly or view it on GitHub

@Anteru
Copy link
Contributor

Anteru commented Apr 4, 2016

This has been merged and will be part of a future release - thanks again :)

jstewart-amd added a commit that referenced this pull request May 18, 2016
@jstewart-amd
Revert style-only changes so that PR from @punkUser will merge cleanly
a7cce88 
#4 has already been
manually merged in our internal codebase, but I am trying to ensure that
@punkUser gets credit on GitHub for his contribution.
@jstewart-amd jstewart-amd merged commit 98a95ea into GPUOpen-Effects:master May 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@punkUser @jstewart-amd @Anteru