Move the clearing of indirect arguments to a seperate pass #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anteru
suggested changes
Sep 26, 2018
| @@ -341,6 +342,11 @@ class SmallBatchChunk | |||
|
|
|||
| context->CSSetShader (filterShader, nullptr, 0); | |||
|
|
|||
| if (currentBatchCount_ > 1) | |||
There was a problem hiding this comment.
What does this bit do? That seems wrong.
The order of execution of FilterCS() within a Dispatch() is not determinate, so we need to run the clear in a previous pass. Also update shader files.
ashleysmithgpu
force-pushed
the
master
branch
from
710ec5a to
2235fab
Compare
|
Updated the shader .inc files as requested, the extra dispatch was an accidental commit from me testing some code, apologies for that. |
|
Thanks a lot for the quick turnaround on the changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order of execution of FilterCS() within a Dispatch() is not determinate, so we need to run the clear in a previous pass.