refactor & feat: re-organized the scripts and added new features #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nanayves <[email protected]>
Signed-off-by: nanayves <[email protected]>
drugilsberg
requested changes
Feb 10, 2023
| @@ -81,6 +81,9 @@ gt4sd = | |||
| training_pipelines/tests/*json | |||
| training_pipelines/tests/*smi | |||
| frameworks/crystals_rfc/*.csv | |||
| frameworks/enzeptional/tests/*pkl | |||
| frameworks/enzeptional/tests/*json | |||
| frameworks/enzeptional/mutation_model/* | |||
There was a problem hiding this comment.
add extension otherwise it's risky
| from gt4sd.frameworks.enzeptional import core | ||
| from gt4sd.frameworks.enzeptional.processing import AutoModelFromHFEmbedding, TAPEEmbedding | ||
|
|
||
| warnings.simplefilter(action="ignore", category=FutureWarning) |
There was a problem hiding this comment.
write it as a pytest unit test, also it would be good to have atomical tests (per method) as well
Comment on lines
638
to
648
| sequence_from_intervals (str): orignial sequence extrcated from interval. | ||
| tmp_results (List[Dict[str, Any]]): the temporary results | ||
| intervals (List[Tuple[int, int]]): list of ranges in the sequence, zero-based. The same interval is applied to all sequences | ||
| selection_method (str): methodology used to selection | ||
| crossover_method (str): methodology used for crossover | ||
| crossover_probability (float, optional): Crossover probability. Used in case Uniform crossover is selected. Defaults to 0.5. | ||
| top_k_selection (Optional[int], optional): Number of samples to select. Defaults to -1. | ||
|
|
||
| Returns: | ||
| List[str]: New samples for the next round of optimization | ||
| """ |
There was a problem hiding this comment.
this docstring style is to compliant and will not the rendered properly in the docs, fix it following the other examples
Comment on lines
389
to
403
| class SelectionGenerator: | ||
| def __init__(self) -> None: | ||
| pass | ||
|
|
||
| def selection( | ||
| self, scores: List[Dict[str, Any]], k: Optional[int] = -1 | ||
| ) -> List[Any]: | ||
| """Select the top k mutated sequences based on the score | ||
| Args: | ||
| scores: dictionary containing sequences and scores. | ||
| k: number of top sequences to return. | ||
| return: | ||
| The top k sequences | ||
| """ | ||
| return list(sorted(scores, key=lambda d: d["score"], reverse=True))[:k] |
There was a problem hiding this comment.
this does not need to be a class, it's just a method :)
|
Old PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: nanayves [email protected]