OF-1902: Review comments

GTMYang · Nov 21, 2019 · a2c82ee · a2c82ee
1 parent 32ae622
commit a2c82ee
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/xmppserver/src/main/java/org/jivesoftware/util/FaviconServlet.java b/xmppserver/src/main/java/org/jivesoftware/util/FaviconServlet.java
@@ -80,7 +80,6 @@ public class FaviconServlet extends HttpServlet {
      * Cache the favicons that we've found.
      */
     private Cache<String, byte[]> hitsCache;
-    private SessionManager sessionManager;
 
     @Override
     public void init(ServletConfig config) throws ServletException {
@@ -100,7 +99,6 @@ public void init(ServletConfig config) throws ServletException {
         // Initialize caches.
         missesCache = CacheFactory.createCache("Favicon Misses");
         hitsCache = CacheFactory.createCache("Favicon Hits");
-        sessionManager = SessionManager.getInstance();
     }
 
     @Override
@@ -123,6 +121,7 @@ public void doGet(HttpServletRequest request, HttpServletResponse response) {
         final String host = request.getParameter("host");
 
         // Validate that we're connected to the host
+        final SessionManager sessionManager = SessionManager.getInstance();
         final Optional<String> optionalHost = Stream
             .concat(sessionManager.getIncomingServers().stream(), sessionManager.getOutgoingServers().stream())
             .filter(remoteServerHost -> remoteServerHost.equalsIgnoreCase(host))