Cache AxisAlignedBB for tile entity render frustrum check #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
needs further profiling to determine if the amount of AABB is actually huge or if it was a build up cause during capturing the memory snapshot This pr might not be needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vanilla code creates a new AxisAlignedBB instance everytime
TileEntity#getRenderBoundingBox()is called, this spams allocation a lot during rendering.I made it cache and return the same bounding box if the coordinates of the tile entity are the same.
This might introduce a bug if the implementation of getRenderBoundingBox is overwritten and depends on other parameters than just the tile entity position.
Needs to be tested with the TE that change the default implementation of
TileEntity#getRenderBoundingBox()Fixes : #689