Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix origin weirdness #799

Merged
merged 2 commits into from
Dec 17, 2024
Merged

fix origin weirdness #799

merged 2 commits into from
Dec 17, 2024

Conversation

embeddedt
Copy link
Collaborator

Reverts #790 (which breaks things, and is insanely complicated) and fixes the issue properly, based on how vanilla 1.7.10 did it. d412bee is the diff against original Angelica prior to #790.

@embeddedt
Copy link
Collaborator Author

To avoid a regression again, someone should test this in the full pack (or any moderately complex 1.7.10 pack) prior to merging.

@nshepperd
Copy link
Contributor

I tried this out on creative and on our server. Everything looks fine in normal usage, though it made some cool-looking abstract art when i tried testing it in the way suggested in #790.

2024-12-17_09 43 51

specifically:

  • at the origin (in personal dimension), everything looks normal
  • when i teleported to far away coordinates, everything looks normal
  • upon teleporting back, things look normal for a second or two then turns into abstract art
  • it's fixable by resetting the renderer (F3+T)

I don't think this is actually a problem/regression, because it's no worse than what happens without the far lands fixes. It doesn't happen when teleporting around shorter distances (1000s of blocks). And everything looks fine on our server.

@nshepperd
Copy link
Contributor

Testing it again, basically the same issue (upon teleporting back to coordinates near the origin) occurs without the fix from this PR, so I think it's an unrelated bug.

@mitchej123 mitchej123 merged commit 99a8136 into master Dec 17, 2024
1 check passed
@mitchej123 mitchej123 deleted the fix-origin-weirdness branch December 17, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants