ML-DSA: add bit packing functions #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds a property about them.
Also modifies simple unpack to use a paradigm I've decided is nicer.
|
As an aside, there's a lot of room in this spec for Cryptol optimization -- replacing indexing and iterators with built-in functions that are faster. We might keep it in mind as low-hanging fruit if folks want to use this in applications but are finding it prohibitively slow. |
marsella
force-pushed
the
183-mldsa-packing
branch
from
1eab71f to
b55ef66
Compare
|
Sorry, I accidentally pushed a commit to the wrong branch. Force-pushed to remove it. |
Let's get a follow on ticket for this, it might be needed for some adjacent work. |
mccleeary-galois
approved these changes
Dec 10, 2024
|
Added #205. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #183.
Nothing particularly groundbreaking here. These are roughly the same as in
DilithiumParameterized.cry, except we use different types here.