Fixed migrate defect, allow migrate the empty directory

If there is an empty directory exists in the $DOCKER_ROOT/containers , that will cause migrate fail. Then docker daemon will initialize failed. This commit allow skips the empty directory. Signed-off-by: Andy Zhang <[email protected]> Change error messages from uppercase to lowercase Change error messages from uppercase to lowercase Signed-off-by: andy <[email protected]>
GaoJie-bupt · Jan 8, 2016 · 098fdb6 · 098fdb6
1 parent d76640d
commit 098fdb6
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/migrate/v1/migratev1.go b/migrate/v1/migratev1.go
@@ -238,12 +238,14 @@ func migrateContainers(root string, ls graphIDMounter, is image.Store, imageMapp
 
 		containerJSON, err := ioutil.ReadFile(filepath.Join(containersDir, id, configFileNameLegacy))
 		if err != nil {
-			return err
+			logrus.Errorf("migrate container error: %v", err)
+			continue
 		}
 
 		var c map[string]*json.RawMessage
 		if err := json.Unmarshal(containerJSON, &c); err != nil {
-			return err
+			logrus.Errorf("migrate container error: %v", err)
+			continue
 		}
 
 		imageStrJSON, ok := c["Image"]
@@ -253,8 +255,10 @@ func migrateContainers(root string, ls graphIDMounter, is image.Store, imageMapp
 
 		var image string
 		if err := json.Unmarshal([]byte(*imageStrJSON), &image); err != nil {
-			return err
+			logrus.Errorf("migrate container error: %v", err)
+			continue
 		}
+
 		imageID, ok := imageMappings[image]
 		if !ok {
 			logrus.Errorf("image not migrated %v", imageID) // non-fatal error