Skip to content

Commit

Permalink
Add playwright to nightly & release workflows (streamlit#7340)
Browse files Browse the repository at this point in the history
* Add playwright to nightly & release

* Fix wrong ref
  • Loading branch information
lukasmasuch authored Sep 15, 2023
1 parent 80ca6d4 commit 9524166
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 1 deletion.
9 changes: 9 additions & 0 deletions .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,11 @@ jobs:
with:
ref: ${{needs.create-nightly-tag.outputs.tag}}

run-playwright-tests:
uses: ./.github/workflows/playwright.yml
with:
ref: ${{needs.create-nightly-tag.outputs.tag}}

test-status-notification:
runs-on: ubuntu-latest

Expand All @@ -107,6 +112,7 @@ jobs:
- run-javascript-tests
- run-py-prod-deps-smoke-test
- run-cypress-tests
- run-playwright-tests

env:
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
Expand All @@ -127,6 +133,8 @@ jobs:
run: python scripts/slack_notifications.py nightly py_prod
- if: ${{ needs.run-cypress-tests.result == 'failure' }}
run: python scripts/slack_notifications.py nightly cypress
- if: ${{ needs.run-playwright-tests.result == 'failure' }}
run: python scripts/slack_notifications.py nightly playwright

create-nightly-build:
runs-on: ubuntu-latest
Expand All @@ -138,6 +146,7 @@ jobs:
- run-javascript-tests
- run-py-prod-deps-smoke-test
- run-cypress-tests
- run-playwright-tests

defaults:
run:
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/release-candidate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@ jobs:
with:
ref: ${{ github.ref_name }}

run-playwright-tests:
uses: ./.github/workflows/playwright.yml
with:
ref: ${{ github.ref_name }}

build-release-candidate:
runs-on: ubuntu-latest

Expand All @@ -35,6 +40,7 @@ jobs:
- run-javascript-tests
- run-py-prod-deps-smoke-test
- run-cypress-tests
- run-playwright-tests

defaults:
run:
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,11 @@ jobs:
with:
ref: ${{ github.ref_name }}

run-playwright-tests:
uses: ./.github/workflows/playwright.yml
with:
ref: ${{ github.ref_name }}

build-release:
runs-on: ubuntu-latest

Expand All @@ -38,6 +43,7 @@ jobs:
- run-javascript-tests
- run-py-prod-deps-smoke-test
- run-cypress-tests
- run-playwright-tests

defaults:
run:
Expand Down
2 changes: 1 addition & 1 deletion scripts/slack_notifications.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ def send_notification():
"js": "on javascript tests",
"py_prod": "on python prod dependencies test",
"cypress": "on cypress tests",
"playwright": "on playwright tests",
"build": "to release",
}

Expand Down Expand Up @@ -74,7 +75,6 @@ def send_notification():


def main():

send_notification()


Expand Down

0 comments on commit 9524166

Please sign in to comment.