Refactor _load_remote_dataset to write CRS information for raster images #3678
+15
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
added
question
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write CRS information in
_load_remote_dataset, so that we don't have to repeat it inload_blue_marble/load_black_marblue.I have very little knowledge about CRS, datums or geodesy stuff, so here are my questions:
CRSfor grids, rather than just images?horizontal_datumandvertical_datum. These attributes were added since the start of the project (Add metadata to Earth relief grids #248). As far as I can see, these attributes are not standard attributes in CF-convention (https://cfconventions.org/Data/cf-conventions/cf-conventions-1.8/cf-conventions.html), and they are part of the CRS. So, perhaps we should remove these two attributes?