Update fetch to be resilient for already unshallow repositories #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ude prune in tags pull
flenny
reviewed
Oct 1, 2024
| run: git fetch --prune --unshallow --tags | ||
| run: | | ||
| if [ "$(git rev-parse --is-shallow-repository)" = "true" ]; then | ||
| git fetch --prune --unshallow |
There was a problem hiding this comment.
Q: What's the reason for removing the --tags option at this point?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if the repo is already unshallow because of earlier steps in the workflow, this action will fail on
git fetch --prune --unshallow --tagsbecause unshallow can only be used with shallow repositories. This checks if the repository is shallow and only runs unshallow if it is, then fetches the tags.