Skip to content

Commit

Permalink
docs: Make contributing guidelines more visible
Browse files Browse the repository at this point in the history
Signed-off-by: Helder Correia <[email protected]>
  • Loading branch information
helderco committed Jun 16, 2022
1 parent 3e6491c commit 9b4ac96
Show file tree
Hide file tree
Showing 11 changed files with 16 additions and 13 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@ Examples:

When it comes to pull requests, the bigger the contribution, the earlier you should talk to maintainers to make sure you're taking the right approach and are not wasting your effort on something that will not get merged.

Extensive contribution guidelines are available in the repository at `docs/guides/1227-contributing.md`, or online at:
Extensive contribution guidelines are available in the repository at `docs/guidelines/1227-contributing.md`, or online at:

[https://docs.dagger.io/1227/contributing](https://docs.dagger.io/1227/contributing)
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ run: bash.#Run & {
## Don’t inline scripts

Avoid inlining scripts (e.g., _sh_, _py_, etc). Instead, put them in their own files
with proper extension, and use `core.#Source` (see [When to use `core.#Source`](1240-core-source.md)) to import into CUE. This allows linting
with proper extension, and use `core.#Source` (see [When to use `core.#Source`](../guides/actions/1240-core-source.md)) to import into CUE. This allows linting
and avoids some limitations (script size, escaping).

Some exceptions may apply (e.g., the script is really short or interpolation is
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ The [#Source core action](../../references/1222-core-actions-reference.md#core-a

The purpose of `core.#Source` is to **enable including files with reusable packages** in a secure way.

The most common example of this is writing scripts in their own file extensions, and importing in an action instead of inlining the contents of the script (see [Don't inline scripts](1226-coding-style.md#dont-inline-scripts)).
The most common example of this is writing scripts in their own file extensions, and importing in an action instead of inlining the contents of the script (see [Don't inline scripts](../../guidelines/1226-coding-style.md#dont-inline-scripts)).

For example, here's how the [netlify package](https://github.com/dagger/dagger/tree/main/pkg/universe.dagger.io/netlify) imports the `deploy.sh` script:

Expand Down
File renamed without changes.
6 changes: 3 additions & 3 deletions docs/guides/concepts/1241-docker.md
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ dist: _run.export.directories."/app/dist" // dagger.#FS

:::tip

As in [Use *top* to match anything](../code/1226-coding-style.md#use-top-to-match-anything), the *export* fields `files`, `secrets` and `directories` are already sufficient to declare the type, so we use *top* (`_`) as a simpler alternative to this:
As in [Use *top* to match anything](../../guidelines/1226-coding-style.md#use-top-to-match-anything), the *export* fields `files`, `secrets` and `directories` are already sufficient to declare the type, so we use *top* (`_`) as a simpler alternative to this:

```cue
export: {
Expand All @@ -264,7 +264,7 @@ You can't export from mounts.

If you need to skip the cache for a `docker.#Run`, set `always: true` (as in "always run").

See [How to always execute an action?](../code/1231-always-execute.md) for more information.
See [How to always execute an action?](../actions/1231-always-execute.md) for more information.

### `docker.#Push`

Expand All @@ -288,7 +288,7 @@ Another useful pattern is to save it in a `json` file in order to be consumed by

:::tip

If you're interested in knowing more about controling the output, check out the [Handling action outputs](../code/1228-handling-outputs.md#controlling-the-output) guide.
If you're interested in knowing more about controling the output, check out the [Handling action outputs](../actions/1228-handling-outputs.md#controlling-the-output) guide.

:::

Expand Down
17 changes: 10 additions & 7 deletions website/sidebars.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,13 +85,6 @@ module.exports = {
collapsed: true,
items: [ { type: "autogenerated", dirName: "guides/concepts", }, ],
},
{
type: "category",
label: "Code Style/Contrib",
collapsible: true,
collapsed: true,
items: [ { type: "autogenerated", dirName: "guides/code", }, ],
},
{
type: "category",
label: "Docker engine",
Expand All @@ -108,6 +101,16 @@ module.exports = {
},
],
},
{
type: "category",
label: "Guidelines",
collapsible: false,
collapsed: false,
items: [
"guidelines/contributing",
"guidelines/coding-style",
],
},
{
type: "category",
label: "References",
Expand Down

0 comments on commit 9b4ac96

Please sign in to comment.