Skip to content

Commit

Permalink
getCookieStore method in ApacheConnectorProvider
Browse files Browse the repository at this point in the history
  • Loading branch information
eoff committed Jun 20, 2014
1 parent 2c8c585 commit 2889fcb
Show file tree
Hide file tree
Showing 2 changed files with 118 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,15 @@
*/
package org.glassfish.jersey.apache.connector;

import javax.ws.rs.client.Client;
import javax.ws.rs.core.Configurable;
import javax.ws.rs.core.Configuration;

import org.apache.http.client.CookieStore;
import org.apache.http.client.HttpClient;
import org.glassfish.jersey.client.Initializable;
import org.glassfish.jersey.client.spi.Connector;
import org.glassfish.jersey.client.spi.ConnectorProvider;

import org.apache.http.client.HttpClient;
import javax.ws.rs.client.Client;
import javax.ws.rs.core.Configurable;
import javax.ws.rs.core.Configuration;

/**
* Connector provider for Jersey {@link Connector connectors} that utilize
Expand Down Expand Up @@ -105,6 +105,7 @@
* @author jorgeluisw at mac.com
* @author Marek Potociar (marek.potociar at oracle.com)
* @author Paul Sandoz (paul.sandoz at oracle.com)
* @author Maksim Mukosey (mmukosey at gmail.com)
* @since 2.5
*/
public class ApacheConnectorProvider implements ConnectorProvider {
Expand All @@ -129,6 +130,40 @@ public Connector getConnector(Client client, Configuration runtimeConfig) {
* @since 2.8
*/
public static HttpClient getHttpClient(Configurable<?> component) {
Connector connector = getConnector(component);

if (connector instanceof ApacheConnector) {
return ((ApacheConnector) connector).getHttpClient();
}

throw new IllegalArgumentException(LocalizationMessages.EXPECTED_CONNECTOR_PROVIDER_NOT_USED());
}

/**
* Retrieve the underlying Apache {@link CookieStore} instance from
* {@link org.glassfish.jersey.client.JerseyClient} or {@link org.glassfish.jersey.client.JerseyWebTarget}
* configured to use {@code ApacheConnectorProvider}.
*
* @param component {@code JerseyClient} or {@code JerseyWebTarget} instance that is configured to use
* {@code ApacheConnectorProvider}.
* @return underlying Apache {@code CookieStore} instance.
*
* @throws java.lang.IllegalArgumentException in case the {@code component} is neither {@code JerseyClient}
* nor {@code JerseyWebTarget} instance or in case the component
* is not configured to use a {@code ApacheConnectorProvider}.
* @since 2.10
*/
public static CookieStore getCookieStore(Configurable<?> component) {
Connector connector = getConnector(component);

if (connector instanceof ApacheConnector) {
return ((ApacheConnector) connector).getCookieStore();
}

throw new IllegalArgumentException(LocalizationMessages.EXPECTED_CONNECTOR_PROVIDER_NOT_USED());
}

private static Connector getConnector(Configurable<?> component) {
if (!(component instanceof Initializable)) {
throw new IllegalArgumentException(
LocalizationMessages.INVALID_CONFIGURABLE_COMPONENT_TYPE(component.getClass().getName()));
Expand All @@ -140,11 +175,6 @@ public static HttpClient getHttpClient(Configurable<?> component) {
initializable.preInitialize();
connector = initializable.getConfiguration().getConnector();
}

if (connector instanceof ApacheConnector) {
return ((ApacheConnector) connector).getHttpClient();
}

throw new IllegalArgumentException(LocalizationMessages.EXPECTED_CONNECTOR_PROVIDER_NOT_USED());
return connector;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
/*
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
*
* Copyright (c) 2014 Oracle and/or its affiliates. All rights reserved.
*
* The contents of this file are subject to the terms of either the GNU
* General Public License Version 2 only ("GPL") or the Common Development
* and Distribution License("CDDL") (collectively, the "License"). You
* may not use this file except in compliance with the License. You can
* obtain a copy of the License at
* http://glassfish.java.net/public/CDDL+GPL_1_1.html
* or packager/legal/LICENSE.txt. See the License for the specific
* language governing permissions and limitations under the License.
*
* When distributing the software, include this License Header Notice in each
* file and include the License file at packager/legal/LICENSE.txt.
*
* GPL Classpath Exception:
* Oracle designates this particular file as subject to the "Classpath"
* exception as provided by Oracle in the GPL Version 2 section of the License
* file that accompanied this code.
*
* Modifications:
* If applicable, add the following below the License Header, with the fields
* enclosed by brackets [] replaced by your own identifying information:
* "Portions Copyright [year] [name of copyright owner]"
*
* Contributor(s):
* If you wish your version of this file to be governed by only the CDDL or
* only the GPL Version 2, indicate your decision by adding "[Contributor]
* elects to include this software in this distribution under the [CDDL or GPL
* Version 2] license." If you don't indicate a single choice of license, a
* recipient has the option to distribute your version of this file under
* either the CDDL, the GPL Version 2 or to extend the choice of license to
* its licensees as provided above. However, if you add GPL Version 2 code
* and therefore, elected the GPL Version 2 license, then the option applies
* only if the new code is made subject to such option by the copyright
* holder.
*/
package org.glassfish.jersey.apache.connector;

import org.apache.http.client.CookieStore;
import org.glassfish.jersey.client.ClientConfig;
import org.junit.Test;

import javax.ws.rs.client.Client;
import javax.ws.rs.client.ClientBuilder;
import javax.ws.rs.client.WebTarget;

import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertSame;

/**
* Test of access to the underlying CookieStore instance used by the connector.
*
* @author Maksim Mukosey (mmukosey at gmail.com)
*/
public class UnderlyingCookieStoreAccessTest {

@Test
public void testCookieStoreInstanceAccess() {
final Client client = ClientBuilder.newClient(new ClientConfig().connectorProvider(new ApacheConnectorProvider()));
final CookieStore csOnClient = ApacheConnectorProvider.getCookieStore(client);
// important: the web target instance in this test must be only created AFTER the client has been pre-initialized
// (see org.glassfish.jersey.client.Initializable.preInitialize method). This is here achieved by calling the
// connector provider's static getCookieStore method above.
final WebTarget target = client.target("http://localhost/");
final CookieStore csOnTarget = ApacheConnectorProvider.getCookieStore(target);

assertNotNull("CookieStore instance set on JerseyClient should not be null.", csOnClient);
assertNotNull("CookieStore instance set on JerseyWebTarget should not be null.", csOnTarget);
assertSame("CookieStore instance set on JerseyClient should be the same instance as the one set on JerseyWebTarget" +
"(provided the target instance has not been further configured).",
csOnClient, csOnTarget
);
}
}

0 comments on commit 2889fcb

Please sign in to comment.