fix: allow the isHidden feature flag config to overwrite client state (…

…microsoft#5110)
Global-localhost · Dec 4, 2020 · 577663e · 577663e
1 parent 98eb0f2
commit 577663e
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/Composer/packages/server/src/services/featureFlags.ts b/Composer/packages/server/src/services/featureFlags.ts
@@ -33,6 +33,16 @@ export class FeatureFlagService {
 
     let saveNeeded = false;
 
+    // check if a hidden feature flag is no longer hidden
+    defaultFeatureFlagKeys.forEach((key: string) => {
+      const currentFlag = FeatureFlagService.currentFeatureFlagMap[key];
+      const defaultFlag = FeatureFlagService.defaultFeatureFlags[key];
+      if (currentFlag.isHidden !== defaultFlag.isHidden) {
+        FeatureFlagService.currentFeatureFlagMap[key].isHidden = FeatureFlagService.defaultFeatureFlags[key].isHidden;
+        saveNeeded = true;
+      }
+    });
+
     // add any new keys defined in the defaults that aren't in current
     defaultFeatureFlagKeys
       .filter((key: string) => !currentFeatureFlagKeys.includes(key))