Skip to content
This repository has been archived by the owner on May 2, 2018. It is now read-only.

Commit

Permalink
image/gif: (temporarily) disable broken tests.
Browse files Browse the repository at this point in the history
The compress/lzw encoder now rejects too-large input bytes, as of
https://go-review.googlesource.com/#/c/11227/, so we can't generate bad
GIFs programatically.

Change-Id: I0b32ce8e1f1776cd6997869db61e687430464e45
Reviewed-on: https://go-review.googlesource.com/11270
Reviewed-by: Nigel Tao <[email protected]>
  • Loading branch information
nigeltao committed Jun 18, 2015
1 parent ccec934 commit 682ecea
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions src/image/gif/reader_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,12 @@ func TestBounds(t *testing.T) {
}

func TestNoPalette(t *testing.T) {
// https://go-review.googlesource.com/#/c/11227/
// changed the lzw encoder to reject input bytes that are too large,
// so that this test code no longer generates the right invalid GIF.
// TODO(nigeltao): re-enable this test somehow.
return

b := &bytes.Buffer{}

// Manufacture a GIF with no palette, so any pixel at all
Expand All @@ -215,6 +221,12 @@ func TestNoPalette(t *testing.T) {
}

func TestPixelOutsidePaletteRange(t *testing.T) {
// https://go-review.googlesource.com/#/c/11227/
// changed the lzw encoder to reject input bytes that are too large,
// so that this test code no longer generates the right invalid GIF.
// TODO(nigeltao): re-enable this test somehow.
return

for _, pval := range []byte{0, 1, 2, 3, 255} {
b := &bytes.Buffer{}

Expand Down

0 comments on commit 682ecea

Please sign in to comment.