Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move availabity to separate columns #999

Merged
merged 11 commits into from
Dec 20, 2024

Conversation

jrobbins
Copy link
Collaborator

This should resolve #790.

In this PR:

  • For missing values, use a blank cell rather than ---.
  • Define four new columns for desktop availability on four browsers and add them to the list of default columns.
  • Allow for a column definition to add a CSS class to the th and td cells in that column (but not its category cell)
  • Make the new columns and existing WPT columns use a centered css class.
  • Define a renderer function for the new columns that shows a gray or full-color icon. Remove the check or minus icon from the WPT cells.
  • Reduce the vertical padding for the header cells to make the double header rows look better.

@jrobbins jrobbins requested a review from jcscottiii December 19, 2024 22:56
Copy link
Collaborator

@jcscottiii jcscottiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some nits.

Also, I filed #1000 to give the same color/grayscale treatment for availability on the feature detail page. Not for now. But just as a future issue.

@jrobbins jrobbins added this pull request to the merge queue Dec 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 20, 2024
@jrobbins jrobbins added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit 6c4afba Dec 20, 2024
6 checks passed
@jrobbins jrobbins deleted the 20241219-move-availabity-to-separate-columns branch December 20, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Move availability to separate columns
2 participants