explicit retry_decorator dependency #153
Conversation
rjschwei
commented
Aug 19, 2013
rjschwei
commented
- use upstream retry_decorator as external dependency
- expects: https://github.com/pnpnpn/retry-decorator
- resolves issues Refactor retry_decorator #152
|
The only thing I think this is missing is updating our submodules in /third_party and updating the gsutil script's THIRD_PARTY_LIBS variable to add the new submodule to the python path for the tarball distribution method. Could you add those too? |
|
We also need you to sign the CLA before we can accept this. Please see instructions here: |
+ expects: https://github.com/pnpnpn/retry-decorator + resolves issues GoogleCloudPlatform#152
|
I updated the gsutil script, and added a submodule to the .gitmodules file, I think that should do the trick. Pushed the changes to my branch on GitHub. Regarding the contribution agreement, to ensure that I can sign it I've asked the legal folks, I expect to hear back by tomorrow. |
|
@rjschwei ping - were you able to sign the CLA? |
|
On 08/23/2013 09:48 PM, Jeff Terrace wrote:
Stuck in legal, juck...... They will get pressure to move from up the chain of command on Monday, Thanks, Robert Schweikert MAY THE SOURCE BE WITH YOU |
|
Contribution agreement signed and sent to [email protected] You should be good to go to merge this. Any chance we can get a tagged release after this is merged? Thanks |
|
Hey Robert, did you send the CLA to [email protected] or [email protected] ? The latter is the correct address. |
|
On 08/28/2013 10:51 PM, Jeff Terrace wrote:
Ugh, it was sent to [email protected]. I just send it to Thanks, Robert Schweikert MAY THE SOURCE BE WITH YOU |
|
There appears to be an issue with the Google mail service :(. My message bounced back as Undeliverable, I had another message that I sent ot a Google group also come back.... |
|
On 08/28/2013 10:51 PM, Jeff Terrace wrote:
After some issues with mail delivery I think I finally managed to get Thanks, Robert Schweikert MAY THE SOURCE BE WITH YOU |
|
Hi Robert, We received your CLA signature - all is in order. Thanks! Mike On Fri, Aug 30, 2013 at 5:55 PM, Robert Schweikert <[email protected]
|
|
Hey Robert, I merged this in and fixed up a couple things with additional commits. Thanks for the contribution! |
