oleaut32: Extend value range before getting absolute value in VarBstr…

…FromI4. Signed-off-by: Daniel Lehman <[email protected]> Signed-off-by: Alexandre Julliard <[email protected]>
Gravemind · Aug 15, 2018 · 1d2ac5d · 1d2ac5d
1 parent 7198499
commit 1d2ac5d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/dlls/oleaut32/tests/vartype.c b/dlls/oleaut32/tests/vartype.c
@@ -4556,7 +4556,7 @@ static void test_VarBstrFromI4(void)
   ok(hres == S_OK, "got hres 0x%08x\n", hres);
   if (bstr)
   {
-    todo_wine ok(memcmp(bstr, int_min, sizeof(int_min)) == 0, "string different\n");
+    ok(memcmp(bstr, int_min, sizeof(int_min)) == 0, "string different\n");
     SysFreeString(bstr);
   }
 

diff --git a/dlls/oleaut32/vartype.c b/dlls/oleaut32/vartype.c
@@ -6453,7 +6453,7 @@ HRESULT WINAPI VarBstrFromI4(LONG lIn, LCID lcid, ULONG dwFlags, BSTR* pbstrOut)
 
   if (lIn < 0)
   {
-    ul64 = (ULONG)-lIn;
+    ul64 = -(LONG64)lIn;
     dwFlags |= VAR_NEGATIVE;
   }
   return VARIANT_BstrFromUInt(ul64, lcid, dwFlags, pbstrOut);