Skip to content

Commit

Permalink
Address feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
andy-armstrong committed Sep 12, 2017
1 parent 3bb6316 commit 8de47f2
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 10 deletions.
6 changes: 3 additions & 3 deletions pavelib/paver_tests/test_eslint.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@
import pavelib.quality


class TestPaverStylelint(unittest.TestCase):
class TestPaverESLint(unittest.TestCase):
"""
For testing run_stylelint
For testing run_eslint
"""

def setUp(self):
super(TestPaverStylelint, self).setUp()
super(TestPaverESLint, self).setUp()

# Mock the paver @needs decorator
self._mock_paver_needs = patch.object(pavelib.quality.run_eslint, 'needs').start()
Expand Down
10 changes: 3 additions & 7 deletions pavelib/quality.py
Original file line number Diff line number Diff line change
Expand Up @@ -335,11 +335,11 @@ def _get_stylelint_violations():
)

try:
return int(_get_count_from_last_line(stylelint_report, "eslint"))
return int(_get_count_from_last_line(stylelint_report, "stylelint"))
except TypeError:
raise BuildFailure(
"Error. Number of eslint violations could not be found in {eslint_report}".format(
eslint_report=stylelint_report
"Error. Number of stylelint violations could not be found in {stylelint_report}".format(
stylelint_report=stylelint_report
)
)

Expand Down Expand Up @@ -369,10 +369,6 @@ def run_stylelint(options):
violations_limit=violations_limit,
)
)
if num_violations > 0:
print("Stylelint succeeded with no more violations than {violations_limit}".format(
violations_limit=violations_limit,
))


@task
Expand Down

0 comments on commit 8de47f2

Please sign in to comment.