Skip to content

Commit

Permalink
chore: notarize Jan app for macos distribution (janhq#278)
Browse files Browse the repository at this point in the history
* chore: notarize Jan app for macos distribution

* chore: fix entitlements path

* chore: update notarize package

* chore: update post signing hook

* chore: use built-in notarize tool

* chore: update entitlements

* chore: binary code sign

* add auto signing binary file script

* Separate build:plugins for darwin os

---------

Co-authored-by: Hien To <>
  • Loading branch information
louis-jan authored Oct 6, 2023
1 parent 3d9b666 commit 0bdd371
Show file tree
Hide file tree
Showing 15 changed files with 28,612 additions and 18 deletions.
17 changes: 12 additions & 5 deletions .github/workflows/build-app.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,17 +37,22 @@ jobs:
env:
VERSION_TAG: ${{ steps.tag.outputs.tag }}

- name: Install yarn dependencies
run: |
yarn install
yarn build:plugins
- name: Get Cer for code signing
run: base64 -d <<< "$CODE_SIGN_P12_BASE64" > /tmp/codesign.p12
shell: bash
env:
CODE_SIGN_P12_BASE64: ${{ secrets.CODE_SIGN_P12_BASE64 }}

- uses: apple-actions/import-codesign-certs@v2
with:
p12-file-base64: ${{ secrets.CODE_SIGN_P12_BASE64 }}
p12-password: ${{ secrets.CODE_SIGN_P12_PASSWORD }}

- name: Install yarn dependencies
run: |
yarn install
yarn build:plugins-darwin
- name: Build and publish app
run: |
yarn build:publish-darwin
Expand All @@ -56,6 +61,8 @@ jobs:
CSC_LINK: "/tmp/codesign.p12"
CSC_KEY_PASSWORD: ${{ secrets.CODE_SIGN_P12_PASSWORD }}
CSC_IDENTITY_AUTO_DISCOVERY: "true"
APPLE_ID: ${{ secrets.APPLE_ID }}
APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_APP_SPECIFIC_PASSWORD }}

build-windows-x64:
runs-on: windows-latest
Expand Down
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
models/**
error.log
node_modules
package-lock.json
*.tgz
yarn.lock
dist
Expand Down
5 changes: 5 additions & 0 deletions electron/auto-sign.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
#!/bin/bash

DEVELOPER_ID="Developer ID Application: Eigenvector Pte Ltd"

find electron -type f -perm +111 -exec codesign -s "Developer ID Application: Eigenvector Pte Ltd (YT49P7GXG4)" --options=runtime {} \;
Loading

0 comments on commit 0bdd371

Please sign in to comment.