Skip to content

Commit

Permalink
Get up to 100 flags (instead of 30). (bazelbuild#41)
Browse files Browse the repository at this point in the history
Instead of hard-coding the limit, we could also make multiple requests,
one for each page (https://developer.github.com/v3/#pagination).

But we don't expect the number of flags to grow indefinitely, so a limit
should work.
  • Loading branch information
laurentlb authored and philwo committed Mar 8, 2019
1 parent 68d5df5 commit de217bc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion bazelisk.go
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ func getIncompatibleFlags(bazeliskHome, resolvedBazelVersion string) ([]string,
if len(version) == 0 {
return nil, fmt.Errorf("invalid version %v", resolvedBazelVersion)
}
url := "https://api.github.com/search/issues?q=repo:bazelbuild/bazel+label:migration-" + version
url := "https://api.github.com/search/issues?per_page=100&q=repo:bazelbuild/bazel+label:migration-" + version
issuesJSON, err := maybeDownload(bazeliskHome, url, "flags-"+version, "list of flags from GitHub")
if err != nil {
return nil, fmt.Errorf("could not get issues from GitHub: %v", err)
Expand Down

0 comments on commit de217bc

Please sign in to comment.