forked from facebookresearch/faiss
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix memory leak for ParameterSpace objects (facebookresearch#3007)
Summary: Pull Request resolved: facebookresearch#3007 There is a complicated interaction between SWIG and the python wrappers where the ownership of ParameterSpace arguments was stolen from Python. This diff adds a test, fixes that behavior and fixes the referenced_objects construction Reviewed By: mlomeli1 Differential Revision: D48404252 fbshipit-source-id: 8afa9e6c15d11451c27864223e33ed1187817224
- Loading branch information
1 parent
e3731f7
commit 69cb877
Showing
2 changed files
with
50 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters