Implement equality for Element
#92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note the following change:
Before:
```julia
julia> R = resistor(1000); circ = Circuit();
julia> add!(circ, R)
Symbol("##296")
julia> add!(circ, R)
Symbol("##296")
julia> ACME.nb(circ)
1
```
After:
```julia
julia> R = resistor(1000); circ = Circuit();
julia> add!(circ, R)
Symbol("##296")
julia> add!(circ, R)
Symbol("##297")
julia> ACME.nb(circ)
2
```
I.e. the same element can now be added twice. In general, element
instances should not have an identity, so the new behaviour seems more
reasonable. (The same `R` could already be added to another circuit
without having any effect on its presence in the first one, for
example.)
So that e.g. `resistor(1000) == resistor(1000)`, which previously gave `false`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements
==(and consistenthash) forElement.It's still the case that
resistor(1000) !== resistor(1000), but that should be seen as an implementation detail that might change in the future.To be consistent, it is now possibly to add the same
Elementinstance for than once to the sameCircuit: