Skip to content

Commit

Permalink
Fixing the typescript types for the event props in Combobox and Setup…
Browse files Browse the repository at this point in the history
…Assistant components. Also fixing the misspelled booleanean type for disabled in the options prop. (salesforce#2970)
  • Loading branch information
bolivierjr authored Nov 16, 2021
1 parent 2a44a95 commit 3d5e5e2
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 12 deletions.
22 changes: 11 additions & 11 deletions components/combobox/combobox.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,16 +58,16 @@ declare module '@salesforce/design-system-react/components/combobox/combobox' {
* _Tested with Mocha testing._
*/
events?: Partial<{
onBlur?: (v: any) => any;
onChange?: (v: any) => any;
onClose?: (v: any) => any;
onFocus?: (v: any) => any;
onOpen?: (v: any) => any;
onRequestClose?: (v: any) => any;
onRequestOpen?: (v: any) => any;
onRequestRemoveSelectedOption?: (v: any) => any;
onSelect?: (v: any) => any;
onSubmit?: (v: any) => any;
onBlur?: (event: React.SyntheticEvent) => any;
onChange?: (event: React.SyntheticEvent, v: any) => any;
onClose?: (event: React.SyntheticEvent, v: any) => any;
onFocus?: (event: React.SyntheticEvent, v: any) => any;
onOpen?: (event: React.SyntheticEvent, v: any) => any;
onRequestClose?: (event: React.SyntheticEvent, v: any) => any;
onRequestOpen?: (event: React.SyntheticEvent, v: any) => any;
onRequestRemoveSelectedOption?: (event: React.SyntheticEvent, v: any) => any;
onSelect?: (event: React.SyntheticEvent, v: any) => any;
onSubmit?: (event: React.SyntheticEvent, v: any) => any;
}>;
/**
* Message to display when the input is in an error state. When this is present, also visually highlights the component as in error. _Tested with snapshot testing._
Expand Down Expand Up @@ -183,7 +183,7 @@ declare module '@salesforce/design-system-react/components/combobox/combobox' {
label?: string;
subTitle?: string;
type?: string;
disabled?: booleanean;
disabled?: boolean;
tooltipContent?: React.ReactNode;
}>[];
/**
Expand Down
2 changes: 1 addition & 1 deletion components/setup-assistant.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ declare module '@salesforce/design-system-react/components/setup-assistant' {
/**
* Function to handle opening / closing of steps when the step is expandable. Passes event object and step `index`, `isOpen`, and `step` props as data.
*/
onStepToggleIsOpen?: (v: any) => any;
onStepToggleIsOpen?: (event: React.SyntheticEvent, v: any) => any;
/**
* Accepts a progress bar component, which will only be visible if `isCard` is enabled
*/
Expand Down

0 comments on commit 3d5e5e2

Please sign in to comment.