chia keys queries for secret words from stdin (Chia-Network#1247)

* chia keys queries for secret words from stdin

* updated changelog

* fixes tests

* fixes chai keys generate

CHANGELOG.md

@@ -13,6 +13,7 @@ for setuptools_scm/PEP 440 reasons.
 ## Changed
 
 - Remove `chia plots "-s" "--stripe_size"` - we now always use the best default of 64K
+- `chia keys add` takes secret words from stdin instead of command line arguments for security
 
 ## 1.0rc5 aka Release Candidate 5 - 2020-03-04
 

src/cmds/keys.py

@@ -38,6 +38,11 @@ def generate_and_add():
     add_private_key_seed(mnemonic)
 
 
+def query_and_add_private_key_seed():
+    mnemonic = input("Enter the mnemonic you want to use: ")
+    add_private_key_seed(mnemonic)
+
+
 def add_private_key_seed(mnemonic: str):
     """
     Add a private key seed to the keyring, with the given mnemonic.
@@ -143,13 +148,10 @@ def show_cmd():
     show_all_keys()
 
 
-@keys_cmd.command("add", short_help="Add a private key by mnemonic in quotes")
-@click.option(
-    "--mnemonic", "-m", help="Enter the mnemonic you want to use surrounded by a single pair of quotes", type=str
-)
+@keys_cmd.command("add", short_help="Add a private key by mnemonic")
 @click.pass_context
-def add_cmd(ctx: click.Context, mnemonic: str):
-    add_private_key_seed(mnemonic)
+def add_cmd(ctx: click.Context):
+    query_and_add_private_key_seed()
     check_keys(ctx.obj["root_path"])