Skip to content

Commit

Permalink
chore: bump rusty_v8 (denoland#740)
Browse files Browse the repository at this point in the history 
Enables pointer compression.
  • Loading branch information
@mmastrac
mmastrac authored May 21, 2024
1 parent b103c92 commit 39a43fd
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 120 deletions.
118 changes: 3 additions & 115 deletions .github/workflows/ci-test-valgrind/suppressions.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,128 +14,16 @@
{
<insert_a_suppression_name_here>
Memcheck:Cond
fun:_ZN4heap4base12_GLOBAL__N_122IteratePointersInStackEPNS0_12StackVisitorEPKvS5_S5_
fun:_ZNK4heap4base5Stack26IteratePointersUntilMarkerEPNS0_12StackVisitorE
fun:_ZN5cppgc8internal10MarkerBase10VisitRootsENS_18EmbedderStackStateE
fun:_ZN5cppgc8internal10MarkerBase16EnterAtomicPauseENS_18EmbedderStackStateE
fun:_ZN2v88internal7CppHeap15EnterFinalPauseEN5cppgc18EmbedderStackStateE
fun:_ZN2v88internal20MarkCompactCollector15MarkLiveObjectsEv
fun:_ZN2v88internal20MarkCompactCollector14CollectGarbageEv
fun:_ZN2v88internal4Heap11MarkCompactEv
fun:_ZN2v88internal4Heap24PerformGarbageCollectionENS0_16GarbageCollectorENS0_23GarbageCollectionReasonEPKc
fun:_ZZN2v88internal4Heap14CollectGarbageENS0_15AllocationSpaceENS0_23GarbageCollectionReasonENS_15GCCallbackFlagsEENK3$_1clEv
fun:_ZN4heap4base5Stack24SetMarkerAndCallbackImplIZN2v88internal4Heap14CollectGarbageENS4_15AllocationSpaceENS4_23GarbageCollectionReasonENS3_15GCCallbackFlagsEE3$_1EEvPS1_PvPKv
fun:_ZN2v88internal7CppHeap15EnterFinalPauseEN5cppgc*
obj:*
}
{
<insert_a_suppression_name_here>
Memcheck:Cond
fun:_ZZN5cppgc8internal26ConservativeTracingVisitor27TraceConservativelyIfNeededEPKvENK3$_0clEPh
fun:_ZN5cppgc8internal26ConservativeTracingVisitor27TraceConservativelyIfNeededEPKv
fun:_ZN2v88internal12_GLOBAL__N_137UnifiedHeapConservativeMarkingVisitor27TraceConservativelyIfNeededEPKv
fun:_ZN4heap4base12_GLOBAL__N_122IteratePointersInStackEPNS0_12StackVisitorEPKvS5_S5_
fun:_ZNK4heap4base5Stack26IteratePointersUntilMarkerEPNS0_12StackVisitorE
fun:_ZN5cppgc8internal10MarkerBase10VisitRootsENS_18EmbedderStackStateE
fun:_ZN5cppgc8internal10MarkerBase16EnterAtomicPauseENS_18EmbedderStackStateE
fun:_ZN2v88internal7CppHeap15EnterFinalPauseEN5cppgc18EmbedderStackStateE
fun:_ZN2v88internal20MarkCompactCollector15MarkLiveObjectsEv
fun:_ZN2v88internal20MarkCompactCollector14CollectGarbageEv
fun:_ZN2v88internal4Heap11MarkCompactEv
fun:_ZN2v88internal4Heap24PerformGarbageCollectionENS0_16GarbageCollectorENS0_23GarbageCollectionReasonEPKc
fun:*ConservativeTracingVisitor27TraceConservativelyIfNeeded*
}
{
<insert_a_suppression_name_here>
Memcheck:Cond
fun:_ZZN5cppgc8internal26ConservativeTracingVisitor27TraceConservativelyIfNeededEPKvENK3$_0clEPh
fun:_ZN5cppgc8internal26ConservativeTracingVisitor27TraceConservativelyIfNeededEPKv
fun:_ZN2v88internal12_GLOBAL__N_137UnifiedHeapConservativeMarkingVisitor27TraceConservativelyIfNeededEPKv
fun:_ZN4heap4base12_GLOBAL__N_122IteratePointersInStackEPNS0_12StackVisitorEPKvS5_S5_
fun:_ZNK4heap4base5Stack26IteratePointersUntilMarkerEPNS0_12StackVisitorE
fun:_ZN5cppgc8internal10MarkerBase10VisitRootsENS_18EmbedderStackStateE
fun:_ZN5cppgc8internal10MarkerBase16EnterAtomicPauseENS_18EmbedderStackStateE
fun:_ZN2v88internal7CppHeap15EnterFinalPauseEN5cppgc18EmbedderStackStateE
fun:_ZN2v88internal20MarkCompactCollector15MarkLiveObjectsEv
fun:_ZN2v88internal20MarkCompactCollector14CollectGarbageEv
fun:_ZN2v88internal4Heap11MarkCompactEv
fun:_ZN2v88internal4Heap24PerformGarbageCollectionENS0_16GarbageCollectorENS0_23GarbageCollectionReasonEPKc
fun:_ZN4heap4base12_GLOBAL__N_122IteratePointersInStack*
}
{
<insert_a_suppression_name_here>
Memcheck:Cond
fun:_ZZN5cppgc8internal26ConservativeTracingVisitor27TraceConservativelyIfNeededEPKvENK3$_0clEPh
fun:_ZN5cppgc8internal26ConservativeTracingVisitor27TraceConservativelyIfNeededEPKv
fun:_ZN2v88internal12_GLOBAL__N_137UnifiedHeapConservativeMarkingVisitor27TraceConservativelyIfNeededEPKv
fun:_ZN4heap4base12_GLOBAL__N_122IteratePointersInStackEPNS0_12StackVisitorEPKvS5_S5_
fun:_ZNK4heap4base5Stack26IteratePointersUntilMarkerEPNS0_12StackVisitorE
fun:_ZN5cppgc8internal10MarkerBase10VisitRootsENS_18EmbedderStackStateE
fun:_ZN5cppgc8internal10MarkerBase16EnterAtomicPauseENS_18EmbedderStackStateE
fun:_ZN2v88internal7CppHeap15EnterFinalPauseEN5cppgc18EmbedderStackStateE
fun:_ZN2v88internal20MarkCompactCollector15MarkLiveObjectsEv
fun:_ZN2v88internal20MarkCompactCollector14CollectGarbageEv
fun:_ZN2v88internal4Heap11MarkCompactEv
fun:_ZN2v88internal4Heap24PerformGarbageCollectionENS0_16GarbageCollectorENS0_23GarbageCollectionReasonEPKc
}
{
<insert_a_suppression_name_here>
Memcheck:Cond
fun:_ZN5cppgc8internal26ConservativeTracingVisitor27TraceConservativelyIfNeededEPKv
fun:_ZN2v88internal12_GLOBAL__N_137UnifiedHeapConservativeMarkingVisitor27TraceConservativelyIfNeededEPKv
fun:_ZN4heap4base12_GLOBAL__N_122IteratePointersInStackEPNS0_12StackVisitorEPKvS5_S5_
fun:_ZNK4heap4base5Stack26IteratePointersUntilMarkerEPNS0_12StackVisitorE
fun:_ZN5cppgc8internal10MarkerBase10VisitRootsENS_18EmbedderStackStateE
fun:_ZN5cppgc8internal10MarkerBase16EnterAtomicPauseENS_18EmbedderStackStateE
fun:_ZN2v88internal7CppHeap15EnterFinalPauseEN5cppgc18EmbedderStackStateE
fun:_ZN2v88internal20MarkCompactCollector15MarkLiveObjectsEv
fun:_ZN2v88internal20MarkCompactCollector14CollectGarbageEv
fun:_ZN2v88internal4Heap11MarkCompactEv
fun:_ZN2v88internal4Heap24PerformGarbageCollectionENS0_16GarbageCollectorENS0_23GarbageCollectionReasonEPKc
fun:_ZZN2v88internal4Heap14CollectGarbageENS0_15AllocationSpaceENS0_23GarbageCollectionReasonENS_15GCCallbackFlagsEENK3$_1clEv
}
{
<insert_a_suppression_name_here>
Memcheck:Cond
fun:_ZZN5cppgc8internal26ConservativeTracingVisitor27TraceConservativelyIfNeededEPKvENK3$_0clEPh
fun:_ZN5cppgc8internal26ConservativeTracingVisitor27TraceConservativelyIfNeededEPKv
fun:_ZN2v88internal12_GLOBAL__N_137UnifiedHeapConservativeMarkingVisitor27TraceConservativelyIfNeededEPKv
fun:_ZN4heap4base12_GLOBAL__N_122IteratePointersInStackEPNS0_12StackVisitorEPKvS5_S5_
fun:_ZNK4heap4base5Stack26IteratePointersUntilMarkerEPNS0_12StackVisitorE
fun:_ZN5cppgc8internal10MarkerBase10VisitRootsENS_18EmbedderStackStateE
fun:_ZN5cppgc8internal10MarkerBase16EnterAtomicPauseENS_18EmbedderStackStateE
fun:_ZN2v88internal7CppHeap15EnterFinalPauseEN5cppgc18EmbedderStackStateE
fun:_ZN2v88internal20MarkCompactCollector15MarkLiveObjectsEv
fun:_ZN2v88internal20MarkCompactCollector14CollectGarbageEv
fun:_ZN2v88internal4Heap11MarkCompactEv
fun:_ZN2v88internal4Heap24PerformGarbageCollectionENS0_16GarbageCollectorENS0_23GarbageCollectionReasonEPKc
}
{
<insert_a_suppression_name_here>
Memcheck:Cond
fun:_ZZN5cppgc8internal26ConservativeTracingVisitor27TraceConservativelyIfNeededEPKvENK3$_0clEPh
fun:_ZN2v88internal12_GLOBAL__N_137UnifiedHeapConservativeMarkingVisitor27TraceConservativelyIfNeededEPKv
fun:_ZN4heap4base12_GLOBAL__N_122IteratePointersInStackEPNS0_12StackVisitorEPKvS5_S5_
fun:_ZNK4heap4base5Stack26IteratePointersUntilMarkerEPNS0_12StackVisitorE
fun:_ZN5cppgc8internal10MarkerBase10VisitRootsENS_18EmbedderStackStateE
fun:_ZN5cppgc8internal10MarkerBase16EnterAtomicPauseENS_18EmbedderStackStateE
fun:_ZN2v88internal7CppHeap15EnterFinalPauseEN5cppgc18EmbedderStackStateE
fun:_ZN2v88internal20MarkCompactCollector15MarkLiveObjectsEv
fun:_ZN2v88internal20MarkCompactCollector14CollectGarbageEv
fun:_ZN2v88internal4Heap11MarkCompactEv
fun:_ZN2v88internal4Heap24PerformGarbageCollectionENS0_16GarbageCollectorENS0_23GarbageCollectionReasonEPKc
fun:_ZZN2v88internal4Heap14CollectGarbageENS0_15AllocationSpaceENS0_23GarbageCollectionReasonENS_15GCCallbackFlagsEENK3$_1clEv
}
{
<insert_a_suppression_name_here>
Memcheck:Cond
fun:_ZZN5cppgc8internal26ConservativeTracingVisitor27TraceConservativelyIfNeededEPKvENK3$_0clEPh
fun:_ZN5cppgc8internal26ConservativeTracingVisitor27TraceConservativelyIfNeededEPKv
fun:_ZN2v88internal12_GLOBAL__N_137UnifiedHeapConservativeMarkingVisitor27TraceConservativelyIfNeededEPKv
fun:_ZN4heap4base12_GLOBAL__N_122IteratePointersInStackEPNS0_12StackVisitorEPKvS5_S5_
fun:_ZNK4heap4base5Stack26IteratePointersUntilMarkerEPNS0_12StackVisitorE
fun:_ZN5cppgc8internal10MarkerBase10VisitRootsENS_18EmbedderStackStateE
fun:_ZN5cppgc8internal10MarkerBase16EnterAtomicPauseENS_18EmbedderStackStateE
fun:_ZN2v88internal7CppHeap15EnterFinalPauseEN5cppgc18EmbedderStackStateE
fun:_ZN2v88internal20MarkCompactCollector15MarkLiveObjectsEv
fun:_ZN2v88internal20MarkCompactCollector14CollectGarbageEv
fun:_ZN2v88internal4Heap11MarkCompactEv
fun:_ZN2v88internal4Heap24PerformGarbageCollectionENS0_16GarbageCollectorENS0_23GarbageCollectionReasonEPKc
}
4 changes: 2 additions & 2 deletions Cargo.lock
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ deno_ops = { version = "0.156.0", path = "./ops" }
serde_v8 = { version = "0.189.0", path = "./serde_v8" }
deno_core_testing = { path = "./testing" }

v8 = { version = "0.91.1", default-features = false }
v8 = { version = "0.92.0", default-features = false }
deno_ast = { version = "=0.35.3", features = ["transpiling"] }
deno_unsync = "0.3.2"
deno_core_icudata = "0.0.73"
Expand Down
1 change: 1 addition & 0 deletions core/runtime/setup.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ fn v8_init(
}

let base_flags = concat!(
" --harmony-import-assertions",
" --wasm-test-streaming",
" --no-validate-asm",
" --turbo_fast_api_calls",
Expand Down
1 change: 0 additions & 1 deletion testing/checkin/runtime/__bootstrap.js
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.

// Allow 'using' to work in TypeScript
Symbol.dispose = Symbol("Symbol.dispose");
Symbol.asyncDispose = Symbol("Symbol.asyncDispose");
4 changes: 3 additions & 1 deletion testing/unit/ops_buffer_test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,7 @@ test(function testBufferTransfer() {
op_v8slice_store("buffer", data);
buffer.transfer(100);
const output = op_v8slice_clone("buffer");
assertArrayEquals(output, new Uint8Array(100));
// Note: after https://chromium-review.googlesource.com/c/v8/v8/+/5394731 landed, the underlying
// AB backingstore is no longer resized.
assertArrayEquals(output, new Uint8Array(1024 * 1024));
});

0 comments on commit 39a43fd

Please sign in to comment.