Table skin, and a few added properties #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zed text according to length
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi HanSolo, like I mentioned yesterday I am also sending you the code for the TableTileSkin. Columns can be set via
tableColumnsproperty, and items viatableItems.I have also added two other properties, which are used in
TileSkinwhen drawing:contentFillfills the view without taking into account top and bottom offsets (useful for example with image)insetsEnabled- if enabled, insets are 0.I added a null check in
SmoothAreaChartTileSkinbecause it was crashing if when init the width and height of view were 0. WhendrawChartwould becalled, points list would contain one element which would have NaN values, and after theHelper.subdividePointsit would have null items.I decided not to pull your changes to keep the flat LED, so please bear patience with code that needs to be removed, in case you want to accept this pull request.
Cheers!