Merge pull request avinash201199#199 from nooras/deleteTodo

Delete todo issue fixed avinash201199#187
HarineMurugan · Oct 9, 2022 · 1b0742e · 1b0742e
2 parents d40f083 + 07837b2
commit 1b0742e
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/assets/js/app.js b/assets/js/app.js
@@ -341,8 +341,10 @@ function removeLocalTodos(todo) {
   } else {
     todos = JSON.parse(localStorage.getItem("todos"));
   }
-  const todoIndex = todo.children[0].innerText;
-  todos.splice(todos.indexOf(todoIndex), 1);
+  if (!isNaN(todo.getAttribute("key"))) {
+    const todoKey = Number(todo.getAttribute("key"));
+    todos = todos.filter((todo) => todo.id !== todoKey);
+  }
   localStorage.setItem("todos", JSON.stringify(todos));
 }
 
@@ -425,7 +427,6 @@ function deleteAll() {
 
 function openmodal(color, message, timer = 3000) {
   //pass color as either 'red' (for error), 'blue' for info and 'green' for success
-  console.log("in");
   document.getElementById("content").classList.add(color);
   document.getElementById("modal-text").innerText = message;
   document.getElementById("Modal").classList.add("true");