fix: load balancer spec in 5XX alarm for iam (passportxyz#3137)

* fix: load balancer spec in 5XX alarm for iam * feat: use --frozen-lockfile when installing with yarn
Hawthorne001 · pull · Feb 22, 2024 · Feb 23, 2024 · Feb 28, 2024 · Feb 28, 2024
commit 0a2912dd8fc1f754e770a8c3dbf90bb5f768e4cf
diff --git a/.github/workflows/build_and_deploy_production.yml b/.github/workflows/build_and_deploy_production.yml
@@ -41,7 +41,7 @@ jobs:
           node-version: 20.8.1
           cache: "yarn"
       - name: Install Packages
-        run: yarn install
+        run: yarn install --frozen-lockfile
       - name: Run Tests
         run: yarn test
       - name: Run Linter
@@ -81,7 +81,7 @@ jobs:
           node-version: 20.8
           cache: "yarn"
       - name: Install Packages
-        run: yarn install
+        run: yarn install --frozen-lockfile
       - name: Load Secrets
         id: op-load-secret
         uses: 1password/load-secrets-action@v1

diff --git a/.github/workflows/build_and_deploy_review.yml b/.github/workflows/build_and_deploy_review.yml
@@ -43,7 +43,7 @@ jobs:
           node-version: 20.8.1
           cache: "yarn"
       - name: Install Packages
-        run: yarn install
+        run: yarn install --frozen-lockfile
       - name: Run Tests
         run: yarn test
       - name: Run Linter

diff --git a/.github/workflows/build_and_deploy_staging.yml b/.github/workflows/build_and_deploy_staging.yml
@@ -41,7 +41,7 @@ jobs:
           node-version: 20.8.1
           cache: "yarn"
       - name: Install Packages
-        run: yarn install
+        run: yarn install --frozen-lockfile
       - name: Run Tests
         run: yarn test
       - name: Run Linter
@@ -81,7 +81,7 @@ jobs:
           node-version: 20.8
           cache: "yarn"
       - name: Install Packages
-        run: yarn install
+        run: yarn install --frozen-lockfile
       - name: Load Secrets
         id: op-load-secret
         uses: 1password/load-secrets-action@v1

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -26,7 +26,7 @@ jobs:
           node-version: 20.8.1
           cache: "yarn"
       - name: Install Packages
-        run: yarn install
+        run: yarn install --frozen-lockfile
       - name: Run Tests
         run: yarn test
       - name: Run Linter
@@ -65,7 +65,7 @@ jobs:
           node-version: 20.8
           cache: "yarn"
       - name: Install Packages
-        run: yarn install
+        run: yarn install --frozen-lockfile
       - name: Load Secrets
         id: op-load-secret
         uses: 1password/load-secrets-action@v1

diff --git a/.github/workflows/deploy_production.yml b/.github/workflows/deploy_production.yml
@@ -40,7 +40,7 @@ jobs:
           node-version: 20.8.1
           cache: "yarn"
       - name: Install Packages
-        run: yarn install
+        run: yarn install --frozen-lockfile
       - name: Run Tests
         run: yarn test
       - name: Run Linter
@@ -80,7 +80,7 @@ jobs:
           node-version: 20.8
           cache: "yarn"
       - name: Install Packages
-        run: yarn install
+        run: yarn install --frozen-lockfile
       - name: Load Secrets
         id: op-load-secret
         uses: 1password/load-secrets-action@v1

diff --git a/.github/workflows/deploy_review.yml b/.github/workflows/deploy_review.yml
@@ -41,7 +41,7 @@ jobs:
           node-version: 20.8.1
           cache: "yarn"
       - name: Install Packages
-        run: yarn install
+        run: yarn install --frozen-lockfile
       - name: Run Tests
         run: yarn test
       - name: Run Linter

diff --git a/.github/workflows/deploy_staging.yml b/.github/workflows/deploy_staging.yml
@@ -40,7 +40,7 @@ jobs:
           node-version: 20.8.1
           cache: "yarn"
       - name: Install Packages
-        run: yarn install
+        run: yarn install --frozen-lockfile
       - name: Run Tests
         run: yarn test
       - name: Run Linter
@@ -80,7 +80,7 @@ jobs:
           node-version: 20.8
           cache: "yarn"
       - name: Install Packages
-        run: yarn install
+        run: yarn install --frozen-lockfile
       - name: Load Secrets
         id: op-load-secret
         uses: 1password/load-secrets-action@v1

diff --git a/.github/workflows/deploy_ui_production.yml b/.github/workflows/deploy_ui_production.yml
@@ -40,7 +40,7 @@ jobs:
           node-version: 20.8.1
           cache: "yarn"
       - name: Install Packages
-        run: yarn install
+        run: yarn install --frozen-lockfile
       - name: Run Tests
         run: yarn test
       - name: Run Linter

diff --git a/.github/workflows/deploy_ui_review.yml b/.github/workflows/deploy_ui_review.yml
@@ -42,7 +42,7 @@ jobs:
           node-version: 20.8.1
           cache: "yarn"
       - name: Install Packages
-        run: yarn install
+        run: yarn install --frozen-lockfile
       - name: Run Tests
         run: yarn test
       - name: Run Linter

diff --git a/.github/workflows/deploy_ui_staging.yml b/.github/workflows/deploy_ui_staging.yml
@@ -40,7 +40,7 @@ jobs:
           node-version: 20.8.1
           cache: "yarn"
       - name: Install Packages
-        run: yarn install
+        run: yarn install --frozen-lockfile
       - name: Run Tests
         run: yarn test
       - name: Run Linter

diff --git a/.github/workflows/release_and_deploy_production.yml b/.github/workflows/release_and_deploy_production.yml
@@ -41,7 +41,7 @@ jobs:
           node-version: 20.8.1
           cache: "yarn"
       - name: Install Packages
-        run: yarn install
+        run: yarn install --frozen-lockfile
       - name: Run Tests
         run: yarn test
       - name: Run Linter
@@ -81,7 +81,7 @@ jobs:
           node-version: 20.8
           cache: "yarn"
       - name: Install Packages
-        run: yarn install
+        run: yarn install --frozen-lockfile
       - name: Load Secrets
         id: op-load-secret
         uses: 1password/load-secrets-action@v1

diff --git a/infra/aws/iam.ts b/infra/aws/iam.ts
@@ -17,7 +17,7 @@ import {
   snsAlertsTopicArn,
   passportXyzDomainName,
   passportXyzHostedZoneId,
-  newPassportDomain
+  newPassportDomain,
 } from "./stacks";
 
 const current = aws.getCallerIdentity({});
@@ -218,7 +218,12 @@ const albPassportXyzTargetGroup = new aws.lb.TargetGroup(`passport-xyz-iam`, {
 /*
  * Alarm for monitoring target 5XX errors
  */
-const coreAlbArnSuffix = coreAlbArn.apply((arn) => arn.split(":").pop());
+const coreAlbArnSuffix = coreAlbArn.apply((arn) => {
+  let ret = arn.split(":").pop();
+  const firstSlashIndex = ret.indexOf("/");
+  ret = firstSlashIndex !== -1 ? ret.substring(firstSlashIndex + 1) : "";
+  return ret;
+});
 const http5xxTargetAlarm = new aws.cloudwatch.MetricAlarm(`HTTP-Target-5XX-passport-xyz-iam`, {
   tags: { ...defaultTags, Name: `HTTP-Target-5XX-passport-xyz-iam` },
   name: `HTTP-Target-5XX-passport-xyz-iam`,
@@ -236,7 +241,6 @@ const http5xxTargetAlarm = new aws.cloudwatch.MetricAlarm(`HTTP-Target-5XX-passp
 
   dimensions: {
     LoadBalancer: coreAlbArnSuffix,
-    TargetGroup: albPassportXyzTargetGroup.arnSuffix,
   },
 
   comparisonOperator: "GreaterThanThreshold",