Skip to content

Commit

Permalink
metrics: migrate test-infra to testify (pingcap#26761)
Browse files Browse the repository at this point in the history
Co-authored-by: Ti Chi Robot <[email protected]>
  • Loading branch information
yedamao and ti-chi-bot authored Aug 2, 2021
1 parent 0bcf830 commit c39ce42
Show file tree
Hide file tree
Showing 2 changed files with 35 additions and 18 deletions.
26 changes: 26 additions & 0 deletions metrics/main_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
// Copyright 2021 PingCAP, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// See the License for the specific language governing permissions and
// limitations under the License.

package metrics

import (
"testing"

"github.com/pingcap/tidb/util/testbridge"
"go.uber.org/goleak"
)

func TestMain(m *testing.M) {
testbridge.WorkaroundGoCheckFlags()
goleak.VerifyTestMain(m)
}
27 changes: 9 additions & 18 deletions metrics/metrics_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,36 +16,27 @@ package metrics
import (
"testing"

. "github.com/pingcap/check"
"github.com/pingcap/errors"
"github.com/pingcap/parser/terror"
"github.com/stretchr/testify/require"
)

func TestT(t *testing.T) {
TestingT(t)
}

var _ = Suite(&testSuite{})

type testSuite struct {
}

func (s *testSuite) TestMetrics(c *C) {
func TestMetrics(t *testing.T) {
// Make sure it doesn't panic.
PanicCounter.WithLabelValues(LabelDomain).Inc()
}

func (s *testSuite) TestRegisterMetrics(c *C) {
func TestRegisterMetrics(t *testing.T) {
// Make sure it doesn't panic.
RegisterMetrics()
}

func (s *testSuite) TestRetLabel(c *C) {
c.Assert(RetLabel(nil), Equals, opSucc)
c.Assert(RetLabel(errors.New("test error")), Equals, opFailed)
func TestRetLabel(t *testing.T) {
require.Equal(t, opSucc, RetLabel(nil))
require.Equal(t, opFailed, RetLabel(errors.New("test error")))
}

func (s *testSuite) TestExecuteErrorToLabel(c *C) {
c.Assert(ExecuteErrorToLabel(errors.New("test")), Equals, `unknown`)
c.Assert(ExecuteErrorToLabel(terror.ErrResultUndetermined), Equals, `global:2`)
func TestExecuteErrorToLabel(t *testing.T) {
require.Equal(t, `unknown`, ExecuteErrorToLabel(errors.New("test")))
require.Equal(t, `global:2`, ExecuteErrorToLabel(terror.ErrResultUndetermined))
}

0 comments on commit c39ce42

Please sign in to comment.