Fix flipping image on preview for simulator (FluidGroup#205)

as iOS 17 fixed geometry issue on simulator. we don't need to use the workaround
Hippo0x0 · Nov 24, 2023 · dcce61e · dcce61e
1 parent 1e203bb
commit dcce61e
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 4 deletions.
diff --git a/Dev/Brightroom.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved b/Dev/Brightroom.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@@ -72,6 +72,15 @@
         "version" : "1.3.1"
       }
     },
+    {
+      "identity" : "swift-syntax",
+      "kind" : "remoteSourceControl",
+      "location" : "https://github.com/apple/swift-syntax.git",
+      "state" : {
+        "revision" : "6ad4ea24b01559dde0773e3d091f1b9e36175036",
+        "version" : "509.0.2"
+      }
+    },
     {
       "identity" : "texture",
       "kind" : "remoteSourceControl",
@@ -104,8 +113,8 @@
       "kind" : "remoteSourceControl",
       "location" : "https://github.com/VergeGroup/Verge.git",
       "state" : {
-        "revision" : "23b6e92fbf88e72ce0546144fbc1dc455cb5d53d",
-        "version" : "11.5.4"
+        "revision" : "a338c22b82c9a686a7131b54fa84ddad773f5c2a",
+        "version" : "12.0.0-beta.4"
       }
     }
   ],

diff --git a/Sources/BrightroomUI/Shared/Components/ImageViews/MetalImageView.swift b/Sources/BrightroomUI/Shared/Components/ImageViews/MetalImageView.swift
@@ -189,16 +189,26 @@ open class MetalImageView: MTKView, CIImageDisplaying, MTKViewDelegate {
     let resolvedImage: CIImage
 
     #if targetEnvironment(simulator)
+
+    if #available(iOS 17, *) {
       // Fixes geometry in Metal
-      resolvedImage =
-        image
+      resolvedImage = image
+        .transformed(by: CGAffineTransform(scaleX: scale, y: scale))
+        .transformed(by: CGAffineTransform(translationX: targetRect.origin.x, y: targetRect.origin.y))
+
+    } else {
+      // Fixes geometry in Metal
+      resolvedImage = image
         .transformed(
           by: CGAffineTransform(scaleX: 1, y: -1)
             .concatenating(.init(translationX: 0, y: image.extent.height))
             .concatenating(.init(scaleX: scale, y: scale))
             .concatenating(.init(translationX: targetRect.origin.x, y: targetRect.origin.y))
         )
 
+    }
+
+
     #else
       resolvedImage =
         image