Skip to content

Commit

Permalink
CMake: Bail out on configuration with FEATURE_cxx20 and MSVC 2019
Browse files Browse the repository at this point in the history
45fd36f triggers internal
compiler errors in MSVC2019 when configuring Qt with -c++std c++20. Bail
out early when trying to configure a C++20 build with MSVC 2019.

Change-Id: Ic0a49c43e08d3d46221c5c060c0b92628898e26e
Reviewed-by:  Alexey Edelev <[email protected]>
Reviewed-by: Thiago Macieira <[email protected]>
jobor committed Mar 27, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1 parent c1ce543 commit 52c7357
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions configure.cmake
Original file line number Diff line number Diff line change
@@ -1407,6 +1407,11 @@ qt_configure_add_report_entry(
MESSAGE "You should use the recommended Emscripten version ${QT_EMCC_RECOMMENDED_VERSION} with this Qt. You have ${EMCC_VERSION}."
CONDITION WASM AND NOT ${EMCC_VERSION} MATCHES ${QT_EMCC_RECOMMENDED_VERSION}
)
qt_configure_add_report_entry(
TYPE ERROR
MESSAGE "Building Qt with C++20 is not supported with MSVC 2019."
CONDITION QT_FEATURE_cxx20 AND MSVC AND MSVC_VERSION LESS "1930"
)
if(WASM)
qt_extra_definition("QT_EMCC_VERSION" "\"${EMCC_VERSION}\"" PUBLIC)
endif()

0 comments on commit 52c7357

Please sign in to comment.