Skip to content

Commit

Permalink
Extract crds.go from infra_test.go
Browse files Browse the repository at this point in the history
Signed-off-by: Daniel Hiller <[email protected]>
  • Loading branch information
dhiller committed Jul 12, 2023
1 parent 0e269cf commit 99e5368
Show file tree
Hide file tree
Showing 4 changed files with 71 additions and 25 deletions.
2 changes: 0 additions & 2 deletions tests/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -272,8 +272,6 @@ go_test(
"//vendor/k8s.io/api/node/v1:go_default_library",
"//vendor/k8s.io/api/policy/v1:go_default_library",
"//vendor/k8s.io/api/policy/v1beta1:go_default_library",
"//vendor/k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1:go_default_library",
"//vendor/k8s.io/apiextensions-apiserver/pkg/client/clientset/clientset:go_default_library",
"//vendor/k8s.io/apimachinery/pkg/api/errors:go_default_library",
"//vendor/k8s.io/apimachinery/pkg/api/resource:go_default_library",
"//vendor/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library",
Expand Down
23 changes: 0 additions & 23 deletions tests/infra_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,6 @@ import (
"k8s.io/client-go/tools/leaderelection/resourcelock"
"k8s.io/client-go/util/retry"

v1ext "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
extclient "k8s.io/apiextensions-apiserver/pkg/client/clientset/clientset"

v1 "kubevirt.io/api/core/v1"
"kubevirt.io/client-go/kubecli"

Expand All @@ -80,7 +77,6 @@ import (
"kubevirt.io/kubevirt/pkg/virt-controller/leaderelectionconfig"
nodelabellerutil "kubevirt.io/kubevirt/pkg/virt-handler/node-labeller/util"
"kubevirt.io/kubevirt/pkg/virt-operator/resource/generate/components"
crds "kubevirt.io/kubevirt/pkg/virt-operator/resource/generate/components"
"kubevirt.io/kubevirt/tests"
"kubevirt.io/kubevirt/tests/console"
cd "kubevirt.io/kubevirt/tests/containerdisk"
Expand Down Expand Up @@ -111,25 +107,6 @@ var _ = Describe("[Serial][sig-compute]Infrastructure", Serial, decorators.SigCo
}
})

Describe("CRDs", func() {
It("[test_id:5177]Should have structural schema", func() {
ourCRDs := []string{crds.VIRTUALMACHINE, crds.VIRTUALMACHINEINSTANCE, crds.VIRTUALMACHINEINSTANCEPRESET,
crds.VIRTUALMACHINEINSTANCEREPLICASET, crds.VIRTUALMACHINEINSTANCEMIGRATION, crds.KUBEVIRT,
crds.VIRTUALMACHINESNAPSHOT, crds.VIRTUALMACHINESNAPSHOTCONTENT,
}

for _, name := range ourCRDs {
ext, err := extclient.NewForConfig(virtClient.Config())
Expect(err).ToNot(HaveOccurred())

crd, err := ext.ApiextensionsV1().CustomResourceDefinitions().Get(context.Background(), name, metav1.GetOptions{})
Expect(err).ToNot(HaveOccurred())

Expect(crd).To(matcher.HaveConditionMissingOrFalse(v1ext.NonStructuralSchema))
}
})
})

Describe("[rfe_id:4102][crit:medium][vendor:[email protected]][level:component]certificates", func() {

It("[test_id:4099] should be rotated when a new CA is created", func() {
Expand Down
4 changes: 4 additions & 0 deletions tests/infrastructure/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,14 @@ load("@io_bazel_rules_go//go:def.bzl", "go_library")
go_library(
name = "go_default_library",
srcs = [
"crds.go",
"downward-metrics.go",
"k8s-client-changes.go",
],
importpath = "kubevirt.io/kubevirt/tests/infrastructure",
visibility = ["//visibility:public"],
deps = [
"//pkg/virt-operator/resource/generate/components:go_default_library",
"//staging/src/kubevirt.io/api/core/v1:go_default_library",
"//staging/src/kubevirt.io/client-go/kubecli:go_default_library",
"//tests:go_default_library",
Expand All @@ -24,6 +26,8 @@ go_library(
"//tests/util:go_default_library",
"//vendor/github.com/onsi/ginkgo/v2:go_default_library",
"//vendor/github.com/onsi/gomega:go_default_library",
"//vendor/k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1:go_default_library",
"//vendor/k8s.io/apiextensions-apiserver/pkg/client/clientset/clientset:go_default_library",
"//vendor/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library",
"//vendor/k8s.io/kube-aggregator/pkg/client/clientset_generated/clientset:go_default_library",
],
Expand Down
67 changes: 67 additions & 0 deletions tests/infrastructure/crds.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
/*
* This file is part of the KubeVirt project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*
* Copyright 2017 Red Hat, Inc.
*
*/

package infrastructure

import (
"context"

"kubevirt.io/kubevirt/tests/decorators"
"kubevirt.io/kubevirt/tests/framework/kubevirt"

. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
v1ext "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
extclient "k8s.io/apiextensions-apiserver/pkg/client/clientset/clientset"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"

"kubevirt.io/kubevirt/tests/framework/matcher"

"kubevirt.io/client-go/kubecli"

crds "kubevirt.io/kubevirt/pkg/virt-operator/resource/generate/components"
)

var _ = Describe("[Serial][sig-compute]Infrastructure", Serial, decorators.SigCompute, func() {
var (
virtClient kubecli.KubevirtClient
)
BeforeEach(func() {
virtClient = kubevirt.Client()
})

Describe("CRDs", func() {
It("[test_id:5177]Should have structural schema", func() {
ourCRDs := []string{crds.VIRTUALMACHINE, crds.VIRTUALMACHINEINSTANCE, crds.VIRTUALMACHINEINSTANCEPRESET,
crds.VIRTUALMACHINEINSTANCEREPLICASET, crds.VIRTUALMACHINEINSTANCEMIGRATION, crds.KUBEVIRT,
crds.VIRTUALMACHINESNAPSHOT, crds.VIRTUALMACHINESNAPSHOTCONTENT,
}

for _, name := range ourCRDs {
ext, err := extclient.NewForConfig(virtClient.Config())
Expect(err).ToNot(HaveOccurred())

crd, err := ext.ApiextensionsV1().CustomResourceDefinitions().Get(context.Background(), name, metav1.GetOptions{})
Expect(err).ToNot(HaveOccurred())

Expect(crd).To(matcher.HaveConditionMissingOrFalse(v1ext.NonStructuralSchema))
}
})
})
})

0 comments on commit 99e5368

Please sign in to comment.