Skip to content

Commit

Permalink
Patches Excessive "The" Out Of Hand Offering (tgstation#73040)
Browse files Browse the repository at this point in the history
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

Hey there,


![image](https://user-images.githubusercontent.com/34697715/215312944-df112bef-2a32-4206-9f46-a2b8c15145a3.png)

"her the hand" is rather silly, so let's trim it down a bit to be nice
and generic. This alert is custom-made for the hand item, and doesn't
really show up in any other context... so it should be fine? The icon
will always be that hand icon so we should be fine.

I wish we could have used the text macros like `\the` or something, but
that doesn't play too well with alerts for some reason? I don't have the
time to look into this so let's just do the simple fix of reducing the
words that show up (looks better without the larger footprint imo).

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game

Less confusing language, better grammar and formatting.

<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->

## Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->

:cl:
spellcheck: Whenever you offer your hand to someone in need, or just
wanting to pull them around- the alert that shows up to them should be a
bit more clear now with a 100% decrease in non-necessary pronouns and
articles.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Co-authored-by: Mothblocks <[email protected]>
  • Loading branch information
san7890 and Mothblocks authored Jan 31, 2023
1 parent ea83acc commit dcbceff
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion code/_onclick/hud/alert.dm
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,7 @@ or shoot a gun to move around via Newton's 3rd Law of Motion."

/atom/movable/screen/alert/give/hand/get_receiving_name(mob/living/carbon/taker, mob/living/carbon/offerer, obj/item/receiving)
additional_desc_text = "Click this alert to take it and let [offerer.p_them()] pull you around!"
return "[offerer.p_their()] [receiving]"
return "[offerer.p_their()] [receiving.name]"


/atom/movable/screen/alert/give/hand/helping/get_receiving_name(mob/living/carbon/taker, mob/living/carbon/offerer, obj/item/receiving)
Expand Down

0 comments on commit dcbceff

Please sign in to comment.