Docker: Change permissions for data dir before attempting to write to…

… it (matrix-org#6389)
HubbeKing · Nov 20, 2019 · 234f55f · 234f55f
1 parent 4f5ca45
commit 234f55f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/changelog.d/6389.bugfix b/changelog.d/6389.bugfix
@@ -0,0 +1 @@
+Fix permission denied error when trying to generate a config file with the docker image.
diff --git a/docker/start.py b/docker/start.py
@@ -169,11 +169,11 @@ def run_generate_config(environ, ownership):
     # log("running %s" % (args, ))
 
     if ownership is not None:
-        args = ["su-exec", ownership] + args
-        os.execv("/sbin/su-exec", args)
-
         # make sure that synapse has perms to write to the data dir.
         subprocess.check_output(["chown", ownership, data_dir])
+
+        args = ["su-exec", ownership] + args
+        os.execv("/sbin/su-exec", args)
     else:
         os.execv("/usr/local/bin/python", args)
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix permission denied error when trying to generate a config file with the docker image.