[Windows] add is highcontrast #153
Conversation
|
Thanks! I'll take a look next week |
| /** | ||
| * <p>check whether OS currently uses high contrast mode.</p> | ||
| */ | ||
| public abstract boolean isHighContrast(); |
There was a problem hiding this comment.
You were correct in #143 that themes are per-app, not per-window. Apologies if it was me who confused and/or suggested this method to be on a Window class.
It could either go on App or on a new class called Theme, similar how Clipboard groups all the functions related to clipboard manipulation. I suggest Theme.
Note: this would be different from dark/light enum, this will be a class containing static methods like isHighContrast() etc. We’ll have to come up with something different re: dark/light
There was a problem hiding this comment.
According to your advice, I added a Theme class.
tonsky
force-pushed
the
main
branch
5 times, most recently
from
70c2fcc to
7c84338
Compare
|
I have one question. (I am not quite familiar with GUI app and this may be a stupid question). |
It’s important that all communication with OS APIs, either it’s on Windows, Linux or Mac, happen from the same thread on which window was created. We (and most of the other UI framewors) call it UI thread. It’s usually a single dedicated thread where even loop was started and it’s usually blocked in that loop.
Simple rule of thumb would be to put it everywhere. |
i10416
force-pushed
the
add-is-highcontrast
branch
from
a21de28 to
0f67087
Compare
i10416
force-pushed
the
add-is-highcontrast
branch
from
0f67087 to
56eb769
Compare
|
Thanks, merged |
|
I’ve pushed macOS impl and removed C++ ThemeWin32 class, seems unnecessary. Please take a look 5a680f3 |
|
Actually, commit is now bada613, I rebased to fix compilation |
separate changes in #143
I separated #143 because it becomes a bit messy.
This PR contains changes related to
isHighcontrastfunctionality.