Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X11: reset scroll distance after re-entering window #220

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

dzaima
Copy link
Contributor

@dzaima dzaima commented Mar 21, 2022

Does the same thing as other apps, resetting the scrolled distance every time the window is re-entered.

@tonsky tonsky merged commit 906ec6e into HumbleUI:main Mar 25, 2022
@tonsky
Copy link
Collaborator

tonsky commented Mar 25, 2022

Thanks! I was unable to repro this on Ubuntu, I guess it already accounts for that. First scroll is indeed ignored

@dzaima dzaima deleted the patch-13 branch March 25, 2022 13:43
@dzaima
Copy link
Contributor Author

dzaima commented Mar 25, 2022

Huh. May be possible to check for OS versions or something, but I don't know how would one go about doing that, and it's not really worth it to save that single scroll event. (didn't ubuntu switch to wayland though, meaning JWM runs on xwayland, which'd do different things than a global X server? Even then, there may still be issues with two open JWM windows within the same Java/X instance)

@tonsky
Copy link
Collaborator

tonsky commented Mar 25, 2022

I don’t think it’s worth saving. I has tested on X11 Ubuntu, not on Wayland

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants