Skip to content

Commit

Permalink
ctdb-vacuum: Process all records not deleted on a remote node
Browse files Browse the repository at this point in the history
This currently skips the last record.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14147
RN: Avoid potential data loss during recovery after vacuuming error

Signed-off-by: Amitay Isaacs <[email protected]>
Reviewed-by: Martin Schwenke <[email protected]>
  • Loading branch information
amitay authored and Amitay Isaacs committed Oct 4, 2019
1 parent fe41238 commit 33f1c9d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ctdb/server/ctdb_vacuum.c
Original file line number Diff line number Diff line change
Expand Up @@ -814,7 +814,7 @@ static void ctdb_process_delete_list(struct ctdb_db_context *ctdb_db,
*/
records = (struct ctdb_marshall_buffer *)outdata.dptr;
rec = (struct ctdb_rec_data_old *)&records->data[0];
while (records->count-- > 1) {
while (records->count-- > 0) {
TDB_DATA reckey, recdata;
struct ctdb_ltdb_header *rechdr;
struct delete_record_data *dd;
Expand Down

0 comments on commit 33f1c9d

Please sign in to comment.