Skip to content

Commit

Permalink
smbd: remove processing of @gmt tokens from the SMB2 server
Browse files Browse the repository at this point in the history
Setting this flag was a hokey hack to trigger @gmt token processing in
filename_convert(). Now that all internal processing is based on struct
smb_filename.NTTIME twrp, we can remove this hack.

With this change, paths containing @gmt tokens received over SMB2 are
subsequently processed unchanged, the @gmt token is not stripped and will hit
the filesystem, mostly resulting in NT_STATUS_NOT_FOUND failures which is the
same behaviour as Windows.

Signed-off-by: Ralph Boehme <[email protected]>
Reviewed-by: Jeremy Allison <[email protected]>
  • Loading branch information
slowfranklin authored and jrasamba committed May 5, 2020
1 parent f689f3c commit 55877f9
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions source3/smbd/smb2_create.c
Original file line number Diff line number Diff line change
Expand Up @@ -1030,7 +1030,6 @@ static void smbd_smb2_create_before_exec(struct tevent_req *req)
{
struct smbd_smb2_create_state *state = tevent_req_data(
req, struct smbd_smb2_create_state);
struct smb_request *smb1req = state->smb1req;
struct smbd_smb2_request *smb2req = state->smb2req;
NTSTATUS status;

Expand Down Expand Up @@ -1238,8 +1237,6 @@ static void smbd_smb2_create_before_exec(struct tevent_req *req)
}

state->twrp_time = BVAL(state->twrp->data.data, 0);

smb1req->flags2 |= FLAGS2_REPARSE_PATH;
}

if (state->qfid != NULL) {
Expand Down

0 comments on commit 55877f9

Please sign in to comment.