Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core - Use fnc_getDescriptiveName for all ACE Action Names #1372

Merged

Conversation

mrschick
Copy link
Contributor

@mrschick mrschick commented Jan 28, 2025

When merged this pull request will:

  • Make all ACE Interaction Names use sys_core_fnc_getDescriptiveName in favour of format ["%1 Chn: %2", _radioName, api_fnc_getRadioChannel].
    I noticed yesterday that the GSA action to connect a PRC-77 displayed the radio's frequency as [MHzKnobPos, KHzKnobPos], since api_fnc_getRadioChannel returns that raw data in its case. getDescriptiveName's return is IMO better in all situations, as it will properly format channel data for all radios and also display useful info like the PTT number.
  • Improve the PRC-343 description to show Bk x Ch y instead of the absolute (overflowing) channel number.
  • Improve the SEM52SL description (and switchChannelFast hint) to show H and P channels as letters instead of numbers.
  • Improve the SEM70 (and SEM90 Rack) description to show x MHz in HW mode and Chn x NetID y in AKW mode.
  • Always pad out the decimal positions of frequency-based radios, i.e: 30.00 MHz for the PRC-77 and 30.000 MHz for the SEM 70 (in HW mode).

@jonpas
Copy link
Member

jonpas commented Jan 28, 2025

Agreed!

@jonpas jonpas added this to the 2.13.1 milestone Jan 28, 2025
@mrschick mrschick marked this pull request as ready for review February 3, 2025 15:56
@jonpas jonpas modified the milestones: 2.13.1, 2.13.0 Feb 4, 2025
@jonpas jonpas merged commit e29480d into IDI-Systems:master Feb 4, 2025
3 checks passed
@mrschick mrschick deleted the fix/descriptive-names-on-actions branch February 4, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants