Added: test case to RegisterOIDCUserCommandTest for blank claim values

IQSS · Nov 21, 2024 · cc99a8b · cc99a8b
1 parent 16f8e04
commit cc99a8b
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/src/test/java/edu/harvard/iq/dataverse/engine/command/impl/RegisterOIDCUserCommandTest.java b/src/test/java/edu/harvard/iq/dataverse/engine/command/impl/RegisterOIDCUserCommandTest.java
@@ -18,6 +18,8 @@
 import edu.harvard.iq.dataverse.util.testing.LocalJvmSettings;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.ValueSource;
 import org.mockito.InjectMocks;
 import org.mockito.Mock;
 import org.mockito.MockitoAnnotations;
@@ -317,26 +319,27 @@ void execute_happyPath_withoutAffiliationAndPosition_claimsInProvider_provideMis
         );
     }
 
-    @Test
+    @ParameterizedTest
+    @ValueSource(strings = {" ", ""})
     @JvmSetting(key = JvmSettings.FEATURE_FLAG, value = "true", varArgs = "api-bearer-auth-provide-missing-claims")
-    void execute_happyPath_withoutAffiliationAndPosition_blankClaimInProviderProvidedInJson_provideMissingClaimsFeatureFlagEnabled() throws AuthorizationException, CommandException {
-        String testUsername = "usernameNotBlank";
-        testUserDTO.setUsername(testUsername);
+    void execute_happyPath_withoutAffiliationAndPosition_blankClaimInProviderProvidedInJson_provideMissingClaimsFeatureFlagEnabled(String testBlankUsername) throws AuthorizationException, CommandException {
+        String testUsernameNotBlank = "usernameNotBlank";
+        testUserDTO.setUsername(testUsernameNotBlank);
         testUserDTO.setTermsAccepted(true);
         testUserDTO.setEmailAddress(null);
         testUserDTO.setFirstName(null);
         testUserDTO.setLastName(null);
 
         when(authServiceStub.verifyOIDCBearerTokenAndGetOAuth2UserRecord(TEST_BEARER_TOKEN)).thenReturn(oAuth2UserRecordStub);
 
-        when(oAuth2UserRecordStub.getUsername()).thenReturn(" ");
+        when(oAuth2UserRecordStub.getUsername()).thenReturn(testBlankUsername);
         when(oAuth2UserRecordStub.getDisplayInfo()).thenReturn(TEST_VALID_DISPLAY_INFO);
 
         sut.execute(contextStub);
 
         verify(authServiceStub, times(1)).createAuthenticatedUser(
                 eq(userRecordIdentifierMock),
-                eq(testUsername),
+                eq(testUsernameNotBlank),
                 eq(new AuthenticatedUserDisplayInfo(
                         TEST_VALID_DISPLAY_INFO.getFirstName(),
                         TEST_VALID_DISPLAY_INFO.getLastName(),