Skip to content

Commit

Permalink
[bugfix] slice description makes charts overflow (apache#993)
Browse files Browse the repository at this point in the history
  • Loading branch information
mistercrunch authored Aug 23, 2016
1 parent 9445549 commit 2bc1674
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions caravel/assets/javascripts/modules/caravel.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ const px = function () {
}
$('.favstar')
.attr('title', 'Click to favorite/unfavorite')
.css('cursor', 'pointer')
.each(show)
.each(function () {
let url = baseUrl + $(this).attr('class_name');
Expand Down Expand Up @@ -203,9 +204,9 @@ const px = function () {
height() {
let others = 0;
const widget = container.parents('.widget');
const sliceDescription = widget.find('.sliceDescription');
const sliceDescription = widget.find('.slice_description');
if (sliceDescription.is(':visible')) {
others += widget.find('.sliceDescription').height() + 25;
others += widget.find('.slice_description').height() + 25;
}
others += widget.find('.chart-header').height();
return widget.height() - others - 10;
Expand Down

0 comments on commit 2bc1674

Please sign in to comment.