[ATSPI] Some house-keeping changes #18
Conversation
Similar to what we did for NodeJS, we put the python3 bindings under a flag that is ON by default, so that users that don't need this binding are not annoyed by the dependency. Now swig is required and imported only if we have either Python or NodeJS bindings ON. The README file was updated accordingly.
| option( | ||
| ATSPI_PYTHON_MODULE | ||
| "Build Python bindings (requires swig and python3)" | ||
| ON |
There was a problem hiding this comment.
As someone whose first exposure to CMake is this project: I assume if we wanted to avoid passing the command line flag to disable building this each time, we could just make a local edit to this file changing this line to OFF? Are there any other ways to change the default locally?
There was a problem hiding this comment.
Well, cmake options are cached (see CMakeCache.txt in build dir), so you only need to specify the flags once. Unless you are passing --fresh option (or cleaning the cmake cache somehow).
I suppose we could also add an environment variable that overrides the default flags, if you are doing constant re-fresh of cmake while working on swift, and it is annoying enough to have to pass the options every time. It would be a simple change.
Silence a compiler warning due to assigning a pid (signed) to an unsigned, in
linux_utils.cc.Add feature flag for python bindings too.
Similar to what we did for NodeJS, we put the python3 bindings under a flag that is ON by default, so that users that don't need this binding are not annoyed by the dependency.
Now swig is required and imported only if we have either Python or NodeJS bindings ON.
The README file was updated accordingly.